Skip to content

test: avoid flaky restart sync in debugger exceptions test#62055

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-test-debugger-exceptions
Open

test: avoid flaky restart sync in debugger exceptions test#62055
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-flaky-test-debugger-exceptions

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented Mar 1, 2026

Summary

In test/parallel/test-debugger-exceptions.js, using stepCommand('r') can intermittently time out while waiting for BREAK_MESSAGE.
For r, this PR switches restart sync to prompt-first waiting (command('r')) and then waits for waitForInitialBreak(), keeping test intent unchanged.

failed CI logs:

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"
  • ./tools/test.py -p actions parallel/test-debugger-exceptions
  • ./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-exceptions
  • ./tools/test.py -p actions parallel/test-debugger-restart-message parallel/test-debugger-run-after-quit-restart
  • CI passes on macOS

Refs: #61762

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 1, 2026
@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch from 217a40b to bfe5f1b Compare March 1, 2026 04:18
@inoway46 inoway46 marked this pull request as ready for review March 1, 2026 04:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (e78ccd8) to head (a3aa5ce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #62055   +/-   ##
=======================================
  Coverage   89.70%   89.70%           
=======================================
  Files         691      691           
  Lines      213935   213935           
  Branches    41050    41040   -10     
=======================================
+ Hits       191907   191909    +2     
- Misses      14095    14109   +14     
+ Partials     7933     7917   -16     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch from bfe5f1b to 64b5b0e Compare March 28, 2026 04:46
@inoway46 inoway46 force-pushed the fix-flaky-test-debugger-exceptions branch from 64b5b0e to a3aa5ce Compare March 28, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants