Skip to content

http: fix for handling on boot timers headers and request #48291

Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom
franciszek-koltuniuk-red:headers-request-timers-fix
Jun 19, 2023
Merged

http: fix for handling on boot timers headers and request #48291
nodejs-github-bot merged 3 commits intonodejs:mainfrom
franciszek-koltuniuk-red:headers-request-timers-fix

Conversation

@franciszek-koltuniuk-red
Copy link
Copy Markdown
Contributor

@franciszek-koltuniuk-red franciszek-koltuniuk-red commented Jun 2, 2023

This change is a fix for handling headersTimeout and requestTimeout
that causes unexpected behavior if the HTTP server is started on boot:

  • the connections to the server can be closed immediately
    with the status HTTP 408

This issue usually happens in IoT or embedded devices where
the reference timestamp (returned by uv_hrtime()) is counted since boot
and can be smaller than the headersTimeout or the requestTimeout value.

Additionally added performance improvement to process the list of
connection only if one of the timers should be processed

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants