Skip to content

Fix overlapping buttons in header#5589

Closed
silverkszlo wants to merge 1 commit intostable33from
fix/overlapping-header
Closed

Fix overlapping buttons in header#5589
silverkszlo wants to merge 1 commit intostable33from
fix/overlapping-header

Conversation

@silverkszlo
Copy link
Copy Markdown
Contributor

@silverkszlo silverkszlo commented Apr 23, 2026

  • Target version: stable33

Summary

The bug was probably introduced in #5496

Fixes this button overlap:

image1

Checklist

  • [ x] Code is properly formatted
  • [ x] Sign-off message is added to all commits
  • [ x] Code is AI-generated
  • Documentation (manuals or wiki) has been updated or is not required

…rlap

Also adds scoped z-index to ensure proper stacking order.

Signed-off-by: silver <s.szmajduch@posteo.de>
@elzody
Copy link
Copy Markdown
Collaborator

elzody commented Apr 23, 2026

This problem also affects the main branch; maybe you could make the PR against that and we can then back-port it, unless there is some specific reason not to?

Also, at least one of the failing Cypress tests (open.spec.js) seem to be related to this change:

cy.get('#viewer .modal-header')
.should('exist')
.and('not.be.visible')
.and('have.css', 'display', 'none')

@elzody elzody linked an issue Apr 23, 2026 that may be closed by this pull request
@silverkszlo
Copy link
Copy Markdown
Contributor Author

This problem also affects the main branch; maybe you could make the PR against that and we can then back-port it, unless there is some specific reason not to?

Also, at least one of the failing Cypress tests (open.spec.js) seem to be related to this change:

cy.get('#viewer .modal-header')
.should('exist')
.and('not.be.visible')
.and('have.css', 'display', 'none')

You're right! I couldn't reproduce it on main at first, but now for some magical reason I can. I'll open a new PR against main, close this one and take a look at the tests. Thank you!

@silverkszlo
Copy link
Copy Markdown
Contributor Author

New PR against main created here: #5599

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker Collabora Code: Title overlay makes menu bar unavailable

2 participants