fix: cannot edit calendar event with external attendees (#8050)#8069
Open
chandrika1993 wants to merge 1 commit intonextcloud:mainfrom
Open
fix: cannot edit calendar event with external attendees (#8050)#8069chandrika1993 wants to merge 1 commit intonextcloud:mainfrom
chandrika1993 wants to merge 1 commit intonextcloud:mainfrom
Conversation
chandrika1993
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
Signed-off-by: Chandrika Mohan <chandrikalov@gmail.com>
chandrika1993
force-pushed
the
fix/external-attendees-8050
branch
from
0b91f8a to
44e1f2d
Compare
Author
|
The build failure looks like a JavaScript heap out of memory error on the CI runner rather than an issue with the code changes. Could a maintainer take a look and re-run the failing jobs if needed? Happy to investigate further if it turns out to be related to the PR. |
Contributor
|
Thank you for the PR. I will look through it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #8050
@GretaD
When an event has external attendees (e.g. user@gmail.com), the CalDAV server rejects the save because it tries to resolve those email addresses as local users and fails.
The fix adds SCHEDULE-AGENT=CLIENT to external attendee properties so the server knows not to handle scheduling for addresses it cannot resolve locally (RFC 6638 Section 7.1).
Also fixed the calendar grid not updating instantly after saving. The server does not return an ETag on 204 responses, which caused an unnecessary extra request before the UI could refresh. A background PROPFIND now restores the ETag immediately after saving, so the grid updates instantly.