Skip to content

netteForms.js: Set validation result CSS classes#64

Open
hranicka wants to merge 2 commits intonette:masterfrom
hranicka:feature/validation-classes
Open

netteForms.js: Set validation result CSS classes#64
hranicka wants to merge 2 commits intonette:masterfrom
hranicka:feature/validation-classes

Conversation

@hranicka
Copy link
Contributor

Sometimes it's useful visually distinguish valid/invalid inputs.

We use something like the code in this PR.
When we need to use another CSS classes or something absolutely different, it's possible redefine Nette.markControlValid and Nette.markControlInvalid.

But I don't know if the PR should be accepted.
Also without it we can redefine Nette.validateControl, call original backed-up function and handle the result.

So most likely this will be closed without merge.
But I can try it and listen your opinions.

@fprochazka
Copy link
Contributor

I like it. Best part is you've essentialy created hooks that can be overriden with custom functions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have nette namespace.

@dg dg force-pushed the master branch 2 times, most recently from 131f7d2 to 532059a Compare May 21, 2015 11:49
@hranicka
Copy link
Contributor Author

This PR should be without any BC break.

Adds CSS classes according to validation result of each control.

Classes are prefixed with nette-* and should be compatible with applications using netteForms.js (thx @Majkl578 ).

Functions can be overridden with custom ones (Nette.markControlValid, Nette.markControlInvalid, Nette.switchClass).

So with this, on target system we can easily style valid/invalid form controls or add custom code executed for validation results.

@dg dg force-pushed the master branch 2 times, most recently from a57a557 to 55d0eb8 Compare June 19, 2015 12:05
@dg dg force-pushed the master branch 2 times, most recently from 9e359e6 to fa84d63 Compare April 5, 2016 23:23
@dg dg force-pushed the master branch 2 times, most recently from 3c1619a to 31bc0a3 Compare April 11, 2016 01:44
@dg dg force-pushed the master branch 7 times, most recently from 6b04b51 to d1c30d6 Compare April 21, 2016 13:03
@dg dg force-pushed the master branch 5 times, most recently from fd381fb to b70e5da Compare May 19, 2016 00:28
@dg dg force-pushed the master branch 2 times, most recently from c996b4c to c8f4f95 Compare June 1, 2016 18:14
@dg dg force-pushed the master branch 2 times, most recently from 27d3e69 to 57295d1 Compare July 9, 2016 12:02
@dg dg force-pushed the master branch 2 times, most recently from 5f19501 to 105a1af Compare January 4, 2017 14:16
@dg dg force-pushed the master branch 14 times, most recently from a6ec22a to c2c4dc3 Compare January 30, 2017 00:54
@dg dg force-pushed the master branch 2 times, most recently from 454e643 to a8c2e65 Compare February 2, 2017 03:03
@dg dg force-pushed the master branch 2 times, most recently from 571b36c to 841e5de Compare March 29, 2017 16:48
@f3l1x
Copy link
Member

f3l1x commented Jun 18, 2017

@hranicka Could you please rebase it? I like an idea. Is there any reason to not to merge it @dg?

@dg dg force-pushed the master branch 4 times, most recently from 8ed13d7 to d6aa86e Compare July 14, 2017 10:58
@dg dg force-pushed the master branch 3 times, most recently from ebfaab8 to 6a0c2b0 Compare July 24, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants