Skip to content

IControl::setValue() ⇒ setCurrentValues() #122

Open
dg wants to merge 1 commit intonette:masterfrom
dg:pull-current
Open

IControl::setValue() ⇒ setCurrentValues() #122
dg wants to merge 1 commit intonette:masterfrom
dg:pull-current

Conversation

@dg
Copy link
Member

@dg dg commented Jun 30, 2016

to solve #114

@dg dg force-pushed the master branch 2 times, most recently from 802f3d4 to ed7ecd7 Compare June 30, 2016 18:18
@dg dg force-pushed the master branch 3 times, most recently from 27d3e69 to 57295d1 Compare July 9, 2016 12:02
@JanTvrdik
Copy link
Contributor

JanTvrdik commented Sep 22, 2016

Looks like pointless BC break to me.

@dg
Copy link
Member Author

dg commented Sep 26, 2016

Point #114

@mrtnzlml
Copy link

I never did not fully understand (or remember) difference between setValue and setDefaultValue and I am using it wrong for sure (at least I think). I am totally supporting some kind of change because there would be a lot of similar developers with the same problem as I have... :)

@JanTvrdik
Copy link
Contributor

I'm aware of the point, but I think that the number of people who accidentally use setValue is very low.

@dg dg force-pushed the master branch 2 times, most recently from 5f19501 to 105a1af Compare January 4, 2017 14:16
@dg dg force-pushed the master branch 14 times, most recently from a6ec22a to c2c4dc3 Compare January 30, 2017 00:54
@hrach
Copy link
Contributor

hrach commented Aug 17, 2017

Just yesterday I have encountered the same weid feeling if I'm doing something wrong. (I was not)

@dg
Copy link
Member Author

dg commented Aug 17, 2017

This is a problem where is no simple and right solution.

@dg dg force-pushed the master branch 2 times, most recently from 2df07d6 to 82e9980 Compare February 11, 2019 11:33
@dg dg force-pushed the master branch 3 times, most recently from 4876961 to b8d3a7c Compare July 8, 2019 09:58
@dg dg force-pushed the master branch 4 times, most recently from 41ff307 to f03a237 Compare November 19, 2019 15:43
@dg dg force-pushed the master branch 2 times, most recently from 341ed9a to 97e6400 Compare December 11, 2019 19:43
@dg dg force-pushed the master branch 3 times, most recently from 9d62255 to ec59537 Compare January 2, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants