[TextField] Remove usage of dangerouslySetInnerHTML (#30776)#37005
Closed
[TextField] Remove usage of dangerouslySetInnerHTML (#30776)#37005
Conversation
Author
|
@mnajdova Can I ask for your help on this PR? Thanks! |
mnajdova
reviewed
May 4, 2023
|
There are indeed other occurences in the 4.x branch that correspond to the other locations that were patched in 8cf69de. The directory has been since renamed |
Author
|
Thanks @aaronshim for pointing this out. Indeed I was missing 3 other instances. @mnajdova I added the fix for all them, it should be good for a single release now. Thanks! |
mnajdova
reviewed
May 10, 2023
Remove unused disable lint rules comments Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Member
|
Closing as we don't publish v4.x anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This back ports the fix removing dangerouslySetInnerHTML from the code base to 4.x version (#30776). This fix is critical to be able to protect products using this library with Trusted types and prevent XSS attacks.