feat: strip basedirs from Rust hash key for cross-machine cache hits#2678
Open
mmastrac wants to merge 1 commit intomozilla:mainfrom
Open
feat: strip basedirs from Rust hash key for cross-machine cache hits#2678mmastrac wants to merge 1 commit intomozilla:mainfrom
mmastrac wants to merge 1 commit intomozilla:mainfrom
Conversation
5 tasks
mmastrac
force-pushed
the
upstream-pr/rust-basedirs
branch
from
3ddc1e9 to
a937ddb
Compare
SCCACHE_BASEDIRS now normalizes cwd, CARGO_MANIFEST_DIR, CARGO_WORKSPACE_DIR, CARGO_TARGET_TMPDIR, CARGO_MANIFEST_PATH, CARGO_BIN_EXE_*, dep-info env var values, and the concatenated argument string in the Rust compiler's hash key computation. This enables cache hits when the same crate is compiled from different absolute paths on different machines (e.g., CI runners with different checkout roots). strip_basedir_prefix now also matches when the value equals the basedir minus its trailing '/', so `cwd == basedir` strips to the empty string rather than passing through. Without this, two machines with different checkout paths produced different hashes even with matching basedirs -- the feature's central claim.
mmastrac
force-pushed
the
upstream-pr/rust-basedirs
branch
from
a937ddb to
3845d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCCACHE_BASEDIRSnow normalizes cwd,CARGO_MANIFEST_DIR,CARGO_WORKSPACE_DIR,CARGO_TARGET_TMPDIR,CARGO_MANIFEST_PATH,CARGO_BIN_EXE_*,dep-infoenv var values, and the concatenated argument string in the Rust compiler's hash key computation. This enables cache hits when the same crate is compiled from different absolute paths on different machines (e.g., CI runners with different checkout roots).This handles arguments that contain absolute paths at non-terminal positions, such as
-Clink-arg=blah,/path/to/somethingor (the nightly-only?)--remap-path-prefix=/full/path=/new.Added a number of unit tests around the functionality, as well as an integration test where we compile a crate from two different directories.
This fixes #2652