chore: switch thirtyfour_sync to thirtyfour#2613
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
+ Coverage 72.82% 73.27% +0.45%
==========================================
Files 68 68
Lines 37114 36907 -207
==========================================
+ Hits 27029 27045 +16
+ Misses 10085 9862 -223 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please update the commit to document the why |
thirtyfour_sync crate is not maintained.
tottoto
force-pushed
the
switch-thirtyfour-sync-to-thirtyfour
branch
from
ef2e3cc to
052a22b
Compare
| return Some(res); | ||
| } else { | ||
| thread::sleep(interval); | ||
| std::thread::sleep(interval); |
There was a problem hiding this comment.
why this change ? seems unrelated
There was a problem hiding this comment.
Since this is now the only place where std::thread is used, importing it solely for this felt unnecessary.
There was a problem hiding this comment.
please avoid unrelated changes :)
There was a problem hiding this comment.
Do you think this is not related?
There was a problem hiding this comment.
I proposed including it in this pull request because it arose as a result of this change, and I thought it would be appropriate to include it.
3 participants
Switches unmaintained
thirtyfour_synctothirtyfour.