fix(signingscript): Bug 2034166 reduce notarization requests#1426
Open
fix(signingscript): Bug 2034166 reduce notarization requests#1426
Conversation
Restructure apple_notarize_stacked to notarize and staple .pkgs before touching .apps, then probe each .app with a staple attempt to see if it was transitively validated by its parent .pkg. Only .apps that fail the probe go through a full notarize/wait/staple fallback. When no .pkg is in the batch, the probe runs a single attempt (no retry) before falling through.
hneiva
force-pushed
the
hneiva/smart-notarize
branch
from
4c1bf58 to
c2ca693
Compare
hneiva
changed the title
Contributor
Author
|
I was able to test this locally with a build from maple:
The important bits:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure apple_notarize_stacked to notarize and staple .pkgs before touching .apps, then probe each .app with a staple attempt to see if it was transitively validated by its parent .pkg. Only .apps that fail the probe go through a full notarize/wait/staple fallback. When no .pkg is in the batch, the probe runs a single attempt (no retry) before falling through.