Skip to content

fix(moon): handle projects without tags in Tags view #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milesj merged 1 commit into from
Feb 26, 2026
+9 −10
Merged

fix(moon): handle projects without tags in Tags view #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vscode-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@
"semver": "^7.7.3"
},
"devDependencies": {
"@moonrepo/types": "^2.0.0",
"@moonrepo/types": "^2.0.1",
"@types/semver": "^7.7.1",
"@types/vscode": "1.103.0",
"@vscode/test-electron": "^2.5.2",
Expand Down
7 changes: 3 additions & 4 deletions packages/vscode-extension/src/projectsView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ class ProjectItem extends TreeItem {
const { project: metadata } = project.config;

if (metadata) {
// @ts-expect-error Support moon v1 `name`
this.tooltip = `${metadata.title || metadata.name} - ${metadata.description}`;
}

Expand Down Expand Up @@ -410,11 +409,11 @@ export class ProjectsProvider implements vscode.TreeDataProvider<TreeItem> {
const tags: Record<string, Project[]> = {};
const untagged: Project[] = [];

this.projects!.forEach((project) => {
if (project.config.tags.length === 0) {
this.projects?.forEach((project) => {
if (project.config.tags?.length === 0) {
untagged.push(project);
} else {
project.config.tags.forEach((tag) => {
project.config.tags?.forEach((tag) => {
tags[tag] ||= [];
tags[tag].push(project);
});
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3164,10 +3164,10 @@ __metadata:
languageName: node
linkType: hard

"@moonrepo/types@npm:^2.0.0":
version: 2.0.0
resolution: "@moonrepo/types@npm:2.0.0"
checksum: 10/c9368b997c5d859fb855787877e1e3275e2f0bcce272758d452c4d04cb236f867387e634eb07f55d884245a54d011d10e6c050a49ca1e0ee218bad67137182d8
"@moonrepo/types@npm:^2.0.0, @moonrepo/types@npm:^2.0.1":
version: 2.0.1
resolution: "@moonrepo/types@npm:2.0.1"
checksum: 10/ecb50ba2ed60e151cebbbb4e04b2788180aa8a033ce2cded26298eb57b356a7a9c00049a6bd338ddddbe0936dfae0c84f27291b47ab4fc92f1439bedf7781d82
languageName: node
linkType: hard

Expand Down Expand Up @@ -11940,7 +11940,7 @@ __metadata:
resolution: "moon-console@workspace:packages/vscode-extension"
dependencies:
"@moonrepo/report": "npm:^2.0.1"
"@moonrepo/types": "npm:^2.0.0"
"@moonrepo/types": "npm:^2.0.1"
"@types/semver": "npm:^7.7.1"
"@types/vscode": "npm:1.103.0"
"@vscode/test-electron": "npm:^2.5.2"
Expand Down
Loading