fix: check all speaker diarization imports to prevent silent failures

[AniruddhaKhandare]

Summary

PR #2818 correctly fixes the NameError for ClusterBackend but as flagged
in its Gemini code review, sv_chunk, postprocess and distribute_spk
could also be None if imports fail — causing a cryptic TypeError later.

Changes

• Initialize all 4 speaker diarization variables to None before try block
• Replace bare except: pass with except Exception as e + warning log
• Check all 4 variables together at usage site with a clear ImportError

Related

Fixes #2806
Related to #2818

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling for speaker diarization module imports, preventing silent failures and providing more informative feedback to users when dependencies are not met. By initializing variables, logging specific import errors, and adding a runtime check, the system becomes more robust and user-friendly regarding optional functionalities.

Highlights

• Improved Speaker Diarization Import Handling: Initialized all speaker diarization related variables (sv_chunk, postprocess, distribute_spk, ClusterBackend) to None before attempting to import them, ensuring a consistent state.
• Enhanced Error Reporting: Replaced a bare 'except: pass' block with a more specific 'except Exception as e' and added a logging warning to clearly indicate when speaker diarization modules fail to import, including the specific error message.
• Runtime Dependency Check: Implemented a check at the point of use for speaker diarization functionality, raising an ImportError if any of the required modules are still None, providing a clear message about missing dependencies (scikit-learn, scipy).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• funasr/auto/auto_model.py
  • Initialized speaker diarization variables (sv_chunk, postprocess, distribute_spk, ClusterBackend) to None.
  • Updated the import error handling to catch specific exceptions and log a warning message.
  • Added a conditional check to raise an ImportError if speaker diarization dependencies are not successfully loaded.

Activity

• The pull request was created to address silent failures in speaker diarization imports, building upon previous work in PR Fix #2806: NameError: name 'ClusterBackend' is not defined #2818.
• The author, AniruddhaKhandare, has provided a clear summary of the changes and their relation to existing issues and pull requests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the issue of silent failures when speaker diarization dependencies are not met. By initializing the module variables to None, catching import exceptions with proper logging, and adding an explicit check at the usage site to raise a clear ImportError, the changes significantly improve the code's robustness and provide better diagnostics for users. The implementation is solid. I have one minor suggestion to improve code cleanliness by removing a redundant import.

[gemini-code-assist]

The logging module is already imported at the top of the file (line 12). This import statement is redundant and can be removed to adhere to the standard practice of having all imports at the top of the module.