fix: use os.dup() to prevent stdio transport from closing real stdin/stdout#2166
Open
giulio-leone wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
Conversation
…stdout When stdio_server() wraps sys.stdin.buffer / sys.stdout.buffer in TextIOWrapper, closing or GC'ing the wrapper also closes the underlying buffer, making sys.stdin/sys.stdout unusable after the server exits. Use os.dup() to duplicate the file descriptors before wrapping, so the wrappers own independent descriptors that can be safely closed without affecting the original stdio handles. Fixes modelcontextprotocol#1933 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running an MCP server with
transport="stdio"causes subsequent stdio operations to fail withValueError: I/O operation on closed fileafter the server exits.Root Cause
In
stdio.py,TextIOWrapper(sys.stdin.buffer)wraps the real stdin buffer directly. When the wrapper is garbage-collected or closed, it also closessys.stdin.buffer, makingsys.stdinunusable.Fix
Use
os.dup()to duplicate the file descriptor before wrapping:This creates an independent file descriptor that can be safely closed without affecting the original
sys.stdin/sys.stdout.Verification
print()works after server exitFixes #1933