Skip to content

fix request ID normalization collision#2151

Open
bschwitz3 wants to merge 2 commits intomodelcontextprotocol:mainfrom
bschwitz3:fix/request-id-normalization-collision
Open

fix request ID normalization collision#2151
bschwitz3 wants to merge 2 commits intomodelcontextprotocol:mainfrom
bschwitz3:fix/request-id-normalization-collision

Conversation

@bschwitz3
Copy link

Summary

  • prevent non-canonical numeric response IDs (for example "01") from being coerced to integer IDs
  • avoid response/request routing collisions in shared session handling
  • add regression test for non-canonical numeric response ID mismatch

Test plan

  • run uv run --frozen pytest tests/shared/test_session.py
  • run full suite as needed

@bschwitz3
Copy link
Author

Hey @maxisbey , if you have a moment, I’d really appreciate your quick look on this fix, I’d value your feedback. :)
thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant