Open
Conversation
This is a slimmer implementation which doesn't keep a global list of open window handles.
Collaborator
|
Thanks for sending these pull requests. I don't think I'll have the time to properly review these for a while, and this is @mkdynamic's project anyway so it would be great if he could check it out and decide what to do anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slimmer implementation which doesn't keep a global list of open window handles.
The downside to not having a local array of handles, specifically in chrome, is that it
loses its original handle, and although it semi regains it, it is no longer seen as the parent.
With #12 you will get this behavior when the main page is reloaded. But under normal use
you will still be seen as the parent.
In #12 I define a global array of window handles that gets attached to the $.popupWindow
object. I believe this adds speed and is cleaner. However, its not necessary in order to regain a
reference to an existing pop up.
See #12 for all the other details.