Skip to content

Add force refresh (alt version)#13

Open
thorst wants to merge 1 commit intomkdynamic:masterfrom
thorst:force-refresh-alt
Open

Add force refresh (alt version)#13
thorst wants to merge 1 commit intomkdynamic:masterfrom
thorst:force-refresh-alt

Conversation

@thorst
Copy link
Copy Markdown
Collaborator

@thorst thorst commented Apr 21, 2014

This is a slimmer implementation which doesn't keep a global list of open window handles.
The downside to not having a local array of handles, specifically in chrome, is that it
loses its original handle, and although it semi regains it, it is no longer seen as the parent.

With #12 you will get this behavior when the main page is reloaded. But under normal use
you will still be seen as the parent.

In #12 I define a global array of window handles that gets attached to the $.popupWindow
object. I believe this adds speed and is cleaner. However, its not necessary in order to regain a
reference to an existing pop up.

See #12 for all the other details.

This is a slimmer implementation which doesn't keep a global list of
open window handles.
@thorst thorst mentioned this pull request Apr 21, 2014
@thorst thorst changed the title Added force refresh (alt version) Add force refresh (alt version) Apr 21, 2014
@lencioni
Copy link
Copy Markdown
Collaborator

Thanks for sending these pull requests. I don't think I'll have the time to properly review these for a while, and this is @mkdynamic's project anyway so it would be great if he could check it out and decide what to do anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants