Revert Arc→Rc change, restore Send + Sync on Settings#893
Merged
max-sixty merged 1 commit intomitsuhiko:masterfrom Mar 30, 2026
Merged
Revert Arc→Rc change, restore Send + Sync on Settings#893max-sixty merged 1 commit intomitsuhiko:masterfrom
max-sixty merged 1 commit intomitsuhiko:masterfrom
Conversation
The Arc→Rc change (mitsuhiko#873) and Send+Sync removal (mitsuhiko#874) were semver-breaking — they removed auto-trait impls from Settings, Redactions, Redaction, and SettingsBindDropGuard. This broke downstream crates like cedar-policy that depend on Send + Sync. Reverts to Arc and restores Send + Sync bounds on Redaction and dynamic_redaction(). Adds Send + Sync to the Comparator trait (new in 1.47.0) for compatibility. Adds a compile-time assertion to prevent future regressions. TODOs mark these as candidates for Rc in the next breaking change. Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
Merged
max-sixty
added a commit
that referenced
this pull request
Mar 30, 2026
Patch release restoring `Send + Sync` on `Settings`, `Redactions`, and `Redaction` after the semver-breaking change in 1.47.0. Follow-up to #893. > _This was written by Claude Code on behalf of @max-sixty_ --------- Co-authored-by: Claude <noreply@anthropic.com>
|
👋 I believe Thanks for maintaining this tool! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Arc→Rc change (#873) and Send+Sync removal (#874) were semver-breaking — they removed auto-trait impls from
Settings,Redactions,Redaction, andSettingsBindDropGuard. This broke downstream crates like cedar-policy that depend onSend + Sync.This reverts to
Arcand restoresSend + Syncbounds onRedactionanddynamic_redaction(). Also addsSend + Syncto theComparatortrait (new in 1.47.0) sinceArc<ActualSettings>requires it. A compile-time assertion prevents future regressions.TODOs mark the
Arcusage andComparatorbounds as candidates for removal in the next breaking change.Thanks to @john-h-kastner-aws for reporting in #873 (comment).