Fix missing telemetry context fields for web extension events#1554
Merged
amitjoshi438 merged 2 commits intomainfrom Apr 15, 2026
Merged
Fix missing telemetry context fields for web extension events#1554amitjoshi438 merged 2 commits intomainfrom
amitjoshi438 merged 2 commits intomainfrom
Conversation
amitjoshi438
force-pushed
the
users/amitjoshi/fix-telemetry-context-fields
branch
from
42dad31 to
7a5c377
Compare
priyanshu92
approved these changes
Apr 15, 2026
PR #1490 removed tenantId, websiteId, dataSource, and schema from the WEB_EXTENSION_INIT_QUERY_PARAMETERS telemetry event but oneDSLogger still reads them to populate global context. This caused these fields to be empty for all web extension events. Restore them sourced from WebExtensionContext which is already populated by initializeWebsiteDetails(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
amitjoshi438
force-pushed
the
users/amitjoshi/fix-telemetry-context-fields
branch
from
7a5c377 to
5ed4bee
Compare
priyanshu92
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tenantId,websiteId,dataSource, andschemafrom theWEB_EXTENSION_INIT_QUERY_PARAMETERStelemetry event, butpopulateVscodeWebAttributes()inoneDSLogger.tsstill reads them to populate global telemetry contextWebExtensionContext(which is already populated byinitializeWebsiteDetails()before the telemetry event is sent)Test plan
🤖 Generated with Claude Code