Skip to content

add max-suggestion config#387

Merged
cpendery merged 9 commits intomicrosoft:mainfrom
krisbiradar:feat-set-suggestion-number
Mar 16, 2026
Merged

add max-suggestion config#387
cpendery merged 9 commits intomicrosoft:mainfrom
krisbiradar:feat-set-suggestion-number

Conversation

@krisbiradar
Copy link
Contributor

@krisbiradar krisbiradar commented Jan 24, 2026

closes #373
We can now see more or less than 5 suggestions in the suggestion box
See below
Screenshot 2026-01-26 at 22 07 39

@krisbiradar
Copy link
Contributor Author

@krisbiradar please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@krisbiradar
Copy link
Contributor Author

Hi @cpendery ! can you please review this and merge or let me know if any changes are required ?

Copy link
Member

@cpendery cpendery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a screenshot of the change working in the PR description & add a readme section under configuration explaining the configuration setting, similar to the useAliases / useNerdFonts

@krisbiradar
Copy link
Contributor Author

it looks like last few changes are breaking npm run dev before syncing the fork it worked correctly and now it asks for version.txt even in dev mode , shall I build a package and then test this or we are going to fix this @cpendery ?

@krisbiradar
Copy link
Contributor Author

it looks like last few changes are breaking npm run dev before syncing the fork it worked correctly and now it asks for version.txt even in dev mode , shall I build a package and then test this or we are going to fix this @cpendery ?

for now I will build a package on local and attach a ss

@krisbiradar
Copy link
Contributor Author

Hi @cpendery took some time but done!!
let me know if you need anything else to merge this

@krisbiradar
Copy link
Contributor Author

any luck @cpendery ?

@cpendery
Copy link
Member

cpendery commented Mar 5, 2026

Sorry @krisbiradar for the delay, looks great!

@cpendery cpendery marked this pull request as draft March 6, 2026 01:14
@cpendery cpendery marked this pull request as ready for review March 6, 2026 01:14
@krisbiradar
Copy link
Contributor Author

hi @cpendery anything from my side?

@cpendery
Copy link
Member

Can you try rebasing onto main in order to kick of fresh checks? I don't see the CI running

@krisbiradar
Copy link
Contributor Author

Can you try rebasing onto main in order to kick of fresh checks? I don't see the CI running

sure!

@krisbiradar
Copy link
Contributor Author

done @cpendery

@cpendery
Copy link
Member

@krisbiradar, looks like you have some lint issues. Can you run npm run lint:fix & then push up

@krisbiradar
Copy link
Contributor Author

done @cpendery

@krisbiradar
Copy link
Contributor Author

@cpendery can you please take a look?

@cpendery cpendery merged commit 57b464c into microsoft:main Mar 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support set suggestions number

2 participants