Skip to content

fix(webpack-plugin): fix webpack plugin loader dirname path construction #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layershifter merged 2 commits into from
Apr 14, 2026
+9 −1
Merged

fix(webpack-plugin): fix webpack plugin loader dirname path construction #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf29b5f
fix: use fileURLToPath for Windows path compatibility in webpack loader
Copilot Apr 13, 2026
6042d68
Update email for @griffel/webpack-plugin
yang991178 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@griffel-webpack-plugin-fix-windows-path.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: use fileURLToPath for Windows path compatibility",
"packageName": "@griffel/webpack-plugin",
"email": "hy.liu@berkeley.edu",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion packages/webpack-plugin/src/webpackLoader.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { EvalCache, transformSync, type TransformOptions, type TransformResult } from '@griffel/transform';
import type * as webpack from 'webpack';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';

import { GriffelCssLoaderContextKey, type SupplementedLoaderContext } from './constants.mjs';
import { generateCSSRules } from './utils/generateCSSRules.mjs';
Expand All @@ -10,7 +11,7 @@ export type WebpackLoaderOptions = Omit<TransformOptions, 'filename' | 'generate

type WebpackLoaderParams = Parameters<webpack.LoaderDefinitionFunction<WebpackLoaderOptions>>;

const __dirname = path.dirname(new URL(import.meta.url).pathname);
const __dirname = path.dirname(fileURLToPath(import.meta.url));
// TODO: do something better, define via exports?
const virtualLoaderPath = path.resolve(__dirname, 'virtual-loader', 'index.cjs');
const virtualCSSFilePath = path.resolve(__dirname, 'virtual-loader', 'griffel.css');
Expand Down
Loading