fix(transform): deduplicate CSS rules from resolveStyleRulesForSlots#834
Open
layershifter wants to merge 2 commits intomicrosoft:mainfrom
Open
fix(transform): deduplicate CSS rules from resolveStyleRulesForSlots#834layershifter wants to merge 2 commits intomicrosoft:mainfrom
layershifter wants to merge 2 commits intomicrosoft:mainfrom
Conversation
dedupeCSSRules() was being called on the previously accumulated cssRulesByBucket instead of the current resolvedCSSRules. This caused duplicate LTR/RTL pairs and cross-slot duplicates to accumulate in the output, roughly doubling CSS bundle size. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📊 Bundle size report✅ No changes found |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dedupeCSSRules()was being called on the previously accumulatedcssRulesByBucketinstead of the freshly resolvedresolvedCSSRules. This meant duplicates within eachmakeStylescall were never removed from the intermediate result.uniqueCSSRules) was only used for metadata — the raw un-deduplicatedresolvedCSSRuleswas appended to the output bucket.This does not affect the final generated CSS (the webpack plugin deduplicates when collecting CSS across modules), but it does cause the
cssRulesByBucketreturned bytransformSync()to contain duplicate entries — LTR/RTL pairs and cross-slot duplicates.Fix
This matches how
@griffel/babel-presethandles deduplication (line 341 oftransformPlugin.ts).Test plan