fix(transform-shaker): preserve class field initializers during tree-shaking#833
Open
layershifter wants to merge 2 commits intomainfrom
Open
fix(transform-shaker): preserve class field initializers during tree-shaking#833layershifter wants to merge 2 commits intomainfrom
layershifter wants to merge 2 commits intomainfrom
Conversation
…shaking The shaker's dependency graph was missing edges from PropertyDefinition nodes to their value children. Since PropertyDefinition is not an expression, baseVisit didn't add dependency edges automatically. This caused class field initializers to be removed while keeping the `=` sign, producing invalid syntax like `field = ;`. Root cause fix: add explicit edges from PropertyDefinition to key/value in the Class visitor, matching how ObjectExpression handles properties. Safety net: when removing a dead PropertyDefinition value, also remove the preceding `=` to avoid producing invalid syntax even if the graph is wrong. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📊 Bundle size report✅ No changes found |
layershifter
force-pushed
the
fix/shaker-class-field-initializers
branch
from
cf933fd to
db0567f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PropertyDefinitionnodes to theirvaluechildrenPropertyDefinitionis not an expression,baseVisitdidn't add dependency edges automatically=sign, producing invalid syntax likefield = ;which then failed inconvertESMtoCJSRoot cause fix: add explicit edges from
PropertyDefinitiontokey/valuein theClassvisitor, matching howObjectExpressionhandles properties.Safety net: when removing a dead
PropertyDefinitionvalue, also remove the preceding=to avoid producing invalid syntax even if the graph is incomplete.Test plan
preserves class field initializers when class is alive🤖 Generated with Claude Code