go.mod: raise minimum go version to go1.24 and use tools directive#348
Open
thaJeztah wants to merge 3 commits intomicrosoft:mainfrom
Open
go.mod: raise minimum go version to go1.24 and use tools directive#348thaJeztah wants to merge 3 commits intomicrosoft:mainfrom
thaJeztah wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
anmaxvl
approved these changes
Mar 23, 2026
Contributor
Author
|
Ah, derp; linting issue will be fixed in my other PR; |
``` tools/mkwinsyscall/mkwinsyscall.go:791:12: SA1019: runtime.GOROOT has been deprecated since Go 1.24: The root used during the Go build will not be meaningful if the binary is copied to another machine. Use the system path to locate the “go” binary, and use “go env GOROOT” to find its GOROOT. (staticcheck) goroot := runtime.GOROOT() ^ ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update the minimum version to go1.24 so that we can use the tools directive instead of using a "tools.go". Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update the minimum version to drop some transitive dependencies. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
|
@anmaxvl OK; I moved the commit over from the other branch, so linting should be happier now (but CI needs a kick to be started again 🤗) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.mod: raise minimum go version to go1.24 and use tools directive
Update the minimum version to go1.24 so that we can use the tools
directive instead of using a "tools.go".
go.mod: update logrus to v1.9.4
Update the minimum version to drop some transitive dependencies.