release-winget.yml: fix submission pwsh script#747
Merged
dscho merged 1 commit intomicrosoft:vfs-2.49.0from Apr 30, 2025
Merged
release-winget.yml: fix submission pwsh script#747dscho merged 1 commit intomicrosoft:vfs-2.49.0from
dscho merged 1 commit intomicrosoft:vfs-2.49.0from
Conversation
Member
|
Strangely, I needed a couple of updates, until the deployment finally worked: microsoft/winget-pkgs#251831. I will force-push the PR branch as soon as CI has finished (so that the |
dscho
approved these changes
Apr 30, 2025
Member
dscho
left a comment
There was a problem hiding this comment.
Verified by this workflow run which opened microsoft/winget-pkgs#251831
dscho
approved these changes
Apr 30, 2025
dscho
previously approved these changes
Apr 30, 2025
Member
During a refactoring I accidentally omitted the `$manifestPath` variable that is required to determine the `$manifestDirectory` for the submission command to WinGet. Since the directory is just a constant, let's update the submission command. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com> Signed-off-by: Johannes Schindelin <johasc@microsoft.com>
dscho
approved these changes
Apr 30, 2025
Member
So apparently it was not merely the last push, but force-pushing to a tree-same commit does not lift that restriction. Surprising, and not what the message said. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


During a refactoring I accidentally omitted the
$manifestPathvariable that is required to determine the$manifestDirectoryfor the submission command to WinGet. Since the$manifestDirectoryis just a constant, let's update the submission command.