Skip to content

fix(vr-tests-web-components): update test scripts and fix story errors #35475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmytrokirpa merged 1 commit into from
Nov 15, 2025
Merged

fix(vr-tests-web-components): update test scripts and fix story errors #35475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/vr-tests-web-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "ESLINT_USE_FLAT_CONFIG=false eslint src --ext .ts,.tsx",
Comment thread
dmytrokirpa marked this conversation as resolved.
"start": "storybook dev",
"type-check": "tsc -p . --baseUrl . --noEmit",
"test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true --stepsApi parameters"
"test-vr": "storywright --browsers chromium --url dist/storybook --destpath dist/screenshots --waitTimeScreenshot 500 --concurrency 4 --headless true --stepsApi parameters --bailOnStoriesError"
Comment thread
davatron5000 marked this conversation as resolved.
},
"dependencies": {
"react": "19.2.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-web-components/src/stories/checkbox/checkbox-indeterminate.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default {
steps: new Steps()
.snapshot('normal', { cropTo: '.testWrapper' })
.executeScript(
'document.getElementsByTagName("fluent-checkbox").forEach(checkbox => checkbox.indeterminate = true)',
'Array.from(document.getElementsByTagName("fluent-checkbox")).forEach(checkbox => checkbox.indeterminate = true)',
Comment thread
davatron5000 marked this conversation as resolved.
)
.snapshot('indeterminate', { cropTo: '.testWrapper' })
.end(),
Expand Down
2 changes: 1 addition & 1 deletion apps/vr-tests-web-components/src/stories/link/link.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const WithLongText = () =>
</style>
<p class="max-width">
This paragraph contains a link which is very long.
<fluent-link href="#">Fluent links wrap correctly between lines when they are very long.</fluent-link> This is
<fluent-link id="${linkId}" href="#">Fluent links wrap correctly between lines when they are very long.</fluent-link> This is
Comment thread
davatron5000 marked this conversation as resolved.
because they are inline elements.
</p>
`);
4 changes: 2 additions & 2 deletions apps/vr-tests-web-components/src/stories/menu-list/menu-list.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,14 @@ export const RadioWithIconsRTL = getStoryVariant(RadioWithIcons, RTL);
export const WithSubmenu = () =>
parse(`
<fluent-menu-list>
<fluent-menu-item>
<fluent-menu-item aria-haspopup="menu">
Comment thread
davatron5000 marked this conversation as resolved.
Item 1
<fluent-menu-list slot="submenu">
<fluent-menu-item> Subitem 1.1 </fluent-menu-item>
<fluent-menu-item> Subitem 1.2 </fluent-menu-item>
</fluent-menu-list>
</fluent-menu-item>
<fluent-menu-item>
<fluent-menu-item aria-haspopup="menu">
Item 2
<fluent-menu-list slot="submenu">
<fluent-menu-item> Subitem 2.1 </fluent-menu-item>
Expand Down
4 changes: 2 additions & 2 deletions apps/vr-tests-web-components/src/stories/radio-group/radio-group.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ export default {
storyWright: {
steps: new Steps()
.snapshot('normal', { cropTo: '.testWrapper' })
.click('[role="radio"]:first-child')
.click('fluent-radio:first-child')
Comment thread
davatron5000 marked this conversation as resolved.
.snapshot('1st selected', { cropTo: '.testWrapper' })
.click('[role="radio"]:nth-child(2)')
.click('fluent-radio:nth-child(2)')
.snapshot('2nd selected', { cropTo: '.testWrapper' })
.end(),
},
Expand Down
4 changes: 2 additions & 2 deletions apps/vr-tests-web-components/src/stories/slider/slider.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ export default {
storyWright: {
steps: new Steps()
.snapshot('normal', { cropTo: '.testWrapper' })
.focus('[role="slider"]')
.keys('[role="slider"]', Keys.rightArrow)
.focus('fluent-slider')
Comment thread
davatron5000 marked this conversation as resolved.
.keys('fluent-slider', Keys.rightArrow)
.snapshot('rightArrow', { cropTo: '.testWrapper' })
.end(),
},
Expand Down