Skip to content

test: Fix comments in cp-v2 pull request#563

Merged
Avijit-Microsoft merged 1 commit intodevfrom
psl-sm-integration
Apr 23, 2026
Merged

test: Fix comments in cp-v2 pull request#563
Avijit-Microsoft merged 1 commit intodevfrom
psl-sm-integration

Conversation

@Ritesh-Microsoft
Copy link
Copy Markdown

Purpose

This pull request makes several improvements to the end-to-end (E2E) test setup, focusing on dependency management, test report generation, and log handling. The main changes include pinning test dependencies to specific major versions, standardizing report and log directory creation, and refining the handling of logs and report paths to increase reliability and maintainability.

Dependency management:

  • Pinned all dependencies in requirements.txt to their respective major versions, ensuring consistent and reproducible test environments.

Test report and log handling improvements:

  • Added logic to create a logs directory at test startup if it does not exist, improving robustness for log file handling.
  • Introduced a REPORT_PATH constant to standardize the report HTML file location, and updated all references to use this path, ensuring consistency between test code and CI workflow. [1] [2] [3]
  • Improved cleanup of log handlers and references by ensuring they are only removed during the teardown phase of tests, preventing premature removal and potential loss of log data. [1] [2]
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions
Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL121016186% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
242 0 💤 0 ❌ 0 🔥 4.022s ⏱️

@Avijit-Microsoft Avijit-Microsoft merged commit 1e962f9 into dev Apr 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants