Remove DefaultContainerRegistry from model when Foundry project uses explicit registry#16438
Draft
Remove DefaultContainerRegistry from model when Foundry project uses explicit registry#16438
Conversation
1 task
…specified via WithContainerRegistry Agent-Logs-Url: https://github.com/microsoft/aspire/sessions/1688cd78-a313-47c9-ba2a-ec06a7f330b8 Co-authored-by: eerhardt <8291187+eerhardt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix foundry projects to remove default container registry
Remove DefaultContainerRegistry from model when Foundry project uses explicit registry
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Foundry projects create a default ACR but don't remove it when an explicit registry is specified via
WithContainerRegistry, resulting in two ACRs being provisioned instead of one.Applies the same pattern already used by AKS (
AzureKubernetesEnvironmentExtensions.WithContainerRegistry): remove the default registry from the model and null the property when an explicit registry is set.Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
7k6vsblobprodcus337.vsblob.vsassets.io/usr/share/dotnet/dotnet dotnet build src/Aspire.Hosting.Foundry/Aspire.Hosting.Foundry.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either: