Reference Only: Benchmark redesign (1662 Feedback)#1664
Draft
rlundeen2 wants to merge 7 commits intomicrosoft:mainfrom
Draft
Reference Only: Benchmark redesign (1662 Feedback)#1664rlundeen2 wants to merge 7 commits intomicrosoft:mainfrom
rlundeen2 wants to merge 7 commits intomicrosoft:mainfrom
Conversation
rlundeen2
commented
Apr 28, 2026
Replace static BENCHMARK_TECHNIQUES list with _get_benchmarkable_specs() that filters SCENARIO_TECHNIQUES using two criteria: - _accepts_adversarial(attack_class): technique CAN use adversarial model - adversarial_chat is None: technique does NOT have one baked in New adversarial techniques added to SCENARIO_TECHNIQUES are auto-discovered. Fix test to use _adversarial_chat private attr on AtomicAttack. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rlundeen2
commented
Apr 28, 2026
| ] | ||
|
|
||
|
|
||
| def _build_benchmark_strategy() -> type[ScenarioStrategy]: |
Contributor
Author
There was a problem hiding this comment.
So much of the strategy is shared with rapid response, these two functions could likely use a helper
build_strategy_from_techniques
rlundeen2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fundamental architectural difference: 1662 treats models as a strategy dimension (permuting them into enum
members), requiring two different strategy classes and a _prepare_strategies override to reconcile them.
This PR treats models as a runtime parameter (looping at create-time), keeping the strategy axis purely about technique selection — which is what it was designed for.