Skip to content

FEAT implement batching for memory interface #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maifeeulasad wants to merge 8 commits into
base: main
Choose a base branch
from
+861 −93
Open

FEAT implement batching for memory interface #1325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3420468
FEAT: implement batching for memory interface (#1325)
romanlutz Apr 24, 2026
99b96b5
Merge remote-tracking branch 'origin/main' into pr-1325-updated
romanlutz Apr 24, 2026
c5cb376
Address review comments on PR #1325
romanlutz Apr 24, 2026
5bf3f03
FIX: address critical review findings
romanlutz Apr 24, 2026
9c6fd01
REFACTOR: extract _query_with_list_params, fix bind variable overflow
romanlutz Apr 24, 2026
d84ce52
TEST: add coverage for effective_batch_size and batch_size parameter
romanlutz Apr 24, 2026
7b5462e
Merge branch 'main' into fix/memory-interface-batching-scale-maifee
romanlutz Apr 24, 2026
db2bed2
Merge branch 'microsoft:main' into fix/memory-interface-batching-scal…
maifeeulasad Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyrit/memory/azure_sql_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ class AzureSQLMemory(MemoryInterface, metaclass=Singleton):
TOKEN_URL = "https://database.windows.net/.default" # The token URL for any Azure SQL database
AZURE_SQL_DB_CONNECTION_STRING = "AZURE_SQL_DB_CONNECTION_STRING"

# Azure SQL supports up to 2100 parameters per statement
_MAX_BIND_VARS: int = 2000

# Azure Storage Account Container datasets and results environment variables
AZURE_STORAGE_ACCOUNT_DB_DATA_CONTAINER_URL: str = "AZURE_STORAGE_ACCOUNT_DB_DATA_CONTAINER_URL"
AZURE_STORAGE_ACCOUNT_DB_DATA_SAS_TOKEN: str = "AZURE_STORAGE_ACCOUNT_DB_DATA_SAS_TOKEN"
Expand Down
Loading