Skip to content

Free ForAll and Self Modifying Check: Set #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregli-msft wants to merge 4 commits into
base: gregli/free-self-base
Choose a base branch
from
Open

Free ForAll and Self Modifying Check: Set #3042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad6f71e
Updates
gregli-msft Mar 20, 2026
8b2bb30
update
gregli-msft Mar 20, 2026
ab41b8e
Merge branch 'gregli/free-self-base' into gregli/free-self-set-2
gregli-msft Mar 20, 2026
00aab94
Merge branch 'gregli/free-self-base' of https://github.com/microsoft/…
gregli-msft Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.PowerFx.Core/Binding/Binder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4987,7 +4987,7 @@ private bool IsIncorrectlySideEffectful(CallNode node, out ErrorResourceKey erro
if (ancestorFunc != null &&
ancestorScopeInfo != null &&
ancestorScopeInfo.HasNondeterministicOperationOrder &&
!func.AllowedWithinNondeterministicOperationOrder)
!func.AllowedWithinNondeterministicOperationOrderWithFeatures(_features))
{
errorKey = TexlStrings.ErrFunctionDisallowedWithinNondeterministicOperationOrder;
badAncestor = ancestorScope.Call;
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/Microsoft.PowerFx.Core/Functions/TexlFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ internal abstract class TexlFunction : IFunction
// that have a nondeterministic operation order (due to multiple async calls).
public virtual bool AllowedWithinNondeterministicOperationOrder => true;

// Allows override for functions for which this depends on enalbed features, in particular EnhancedIterationFunctionChecks.
public virtual bool AllowedWithinNondeterministicOperationOrderWithFeatures(Features features) => AllowedWithinNondeterministicOperationOrder;

/// <summary>
/// Whether the function always produces a visible error if CheckTypes returns invalid.
/// This can be used to prevent the overall "Function has invalid arguments" error.
Expand Down
7 changes: 5 additions & 2 deletions src/libraries/Microsoft.PowerFx.Interpreter/Functions/SetFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ internal class RecalcEngineSetFunction : TexlFunction
public override bool IsSelfContained => false;

// Set() of a simple identifier is not a mutation through a reference (a mutate), but rather changing the reference (a true set).
public override bool MutatesArg(int argIndex, TexlNode arg) => argIndex == 0 && arg.Kind != NodeKind.FirstName;
public override bool MutatesArg(int argIndex, TexlNode arg) => argIndex == 0 && arg.Kind != NodeKind.FirstName;

// If enhanced checks are enabled, overrides default true to block Set() from being used in iterator functions.
public override bool AllowedWithinNondeterministicOperationOrderWithFeatures(Features features) => !features.EnhancedIterationChecks;

public override IEnumerable<StringGetter[]> GetSignatures()
{
Expand All @@ -48,7 +51,7 @@ public RecalcEngineSetFunction()
0, // no lambdas
2,
2)
{
{
}

public override bool CheckTypes(CheckTypesContext context, TexlNode[] args, DType[] argTypes, IErrorContainer errors, out DType returnType, out Dictionary<TexlNode, DType> nodeToCoercedTypeMap)
Expand Down
Loading