Conversation
There was a problem hiding this comment.
Pull request overview
Syncs a couple of local dotNet lab changes back into the educational CodeTour/C# completion exercise content.
Changes:
- Adjusts end-of-file formatting in
dotNet/src/Completions.cs(final brace/newline diff). - Adds a blank line/spacing change in the “Completions #6” step in the dotNet CodeTour.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dotNet/src/Completions.cs | Minor formatting change at the end of the completions exercise file. |
| dotNet/.tours/advanced-ghcp-lab-for-c.tour | Minor formatting change within the “Completions #6” CodeTour step block. |
| @@ -57,6 +57,7 @@ | |||
| { | |||
| "file": "src/Completions.cs", | |||
| "description": "Let's try to be more specific, when you type \"`dynamic filterAlertsWithLongName`\" what is the length you get in the code? Stop reading and give it try, then continue reading.\r\n\r\nDoes that \"satisfy\" the requirement? What if you wanted it to be a little longer let's say more than 12 characters?\r\n\r\n You have two options:\r\n\r\n1. To write a hard-coded value in the variable name and that's the generated code you get, i.e. filterAlertsWithNameLongerThan12. Then you can rename the variable to your needs.\r\n\r\n2. Create a variable, let's create a const with a value of 15 named MAX_ALERT_NAME. Now when you write `filterAlertWithLongName` Copilot will take that into account and use the variable", | |||
There was a problem hiding this comment.
In the Completions #6 step description, the example variable name is inconsistent: it first references dynamic filterAlertsWithLongName but later says to write filterAlertWithLongName (missing the "s" and the dynamic prefix). This can confuse learners; please make the example consistent throughout the paragraph.
| "description": "Let's try to be more specific, when you type \"`dynamic filterAlertsWithLongName`\" what is the length you get in the code? Stop reading and give it try, then continue reading.\r\n\r\nDoes that \"satisfy\" the requirement? What if you wanted it to be a little longer let's say more than 12 characters?\r\n\r\n You have two options:\r\n\r\n1. To write a hard-coded value in the variable name and that's the generated code you get, i.e. filterAlertsWithNameLongerThan12. Then you can rename the variable to your needs.\r\n\r\n2. Create a variable, let's create a const with a value of 15 named MAX_ALERT_NAME. Now when you write `filterAlertWithLongName` Copilot will take that into account and use the variable", | |
| "description": "Let's try to be more specific, when you type \"`dynamic filterAlertsWithLongName`\" what is the length you get in the code? Stop reading and give it try, then continue reading.\r\n\r\nDoes that \"satisfy\" the requirement? What if you wanted it to be a little longer let's say more than 12 characters?\r\n\r\n You have two options:\r\n\r\n1. To write a hard-coded value in the variable name and that's the generated code you get, i.e. filterAlertsWithNameLongerThan12. Then you can rename the variable to your needs.\r\n\r\n2. Create a variable, let's create a const with a value of 15 named MAX_ALERT_NAME. Now when you write `filterAlertsWithLongName` Copilot will take that into account and use the variable", |
|
|
||
| "line": 20, | ||
| "title": "Completions #6" |
There was a problem hiding this comment.
PR description mentions reordering the dotNet "secret" strings, but this PR's diff only shows a formatting change here and a newline/brace change in Completions.cs. If the secret reordering was intended, it looks missing from this PR; otherwise, please update the PR description to match the actual changes.
This PR brings in two local changes that were diverged from origin/main:\n\n1. Change order of secrets to 'make sense' - Reorders the easter egg secret strings across the dotNet project files\n2. Fix var in code tour - Fixes the variable prefix in the Completions #6 tour step description\n\nConflicts were resolved by keeping origin/main's versions where applicable (net8.0 upgrade, updated tour descriptions).