Distance computation: Fix SSE instructions#672
Open
twuebker wants to merge 1 commit intomicrosoft:cpp_mainfrom
Open
Distance computation: Fix SSE instructions#672twuebker wants to merge 1 commit intomicrosoft:cpp_mainfrom
twuebker wants to merge 1 commit intomicrosoft:cpp_mainfrom
Conversation
Currently, invalid SSE instructions like _mm128_loadu_ps are used. This causes DiskANN compilation to fail on machines that only support SSE and not AVX. Instead, it should be _mm_loadu_ps. Change the instructions to the correct ones.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes compilation on SSE-only (non-AVX) builds by replacing invalid/nonexistent SSE intrinsic names in the distance computation kernels, keeping the SSE2 fallback path functional.
Changes:
- Replace
_mm128_loadu_ps/_mm128_mul_ps/_mm128_add_pswith the correct_mm_loadu_ps/_mm_mul_ps/_mm_add_psin the SSE dot-product macro. - Replace
_mm128_*intrinsics with correct_mm_*intrinsics in the SSE L2-norm macro.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tmp2 = _mm128_loadu_ps(addr2); \ | ||
| tmp1 = _mm128_mul_ps(tmp1, tmp2); \ | ||
| dest = _mm128_add_ps(dest, tmp1); | ||
| tmp1 = _mm_loadu_ps(addr1); \ |
Contributor
There was a problem hiding this comment.
@copilot check that the new instructions do run on SSE and are correct equivalents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
Currently, invalid SSE instructions like _mm128_loadu_ps are used. This causes DiskANN compilation to fail on machines that only support SSE and not AVX. Instead, it should be _mm_loadu_ps.
Change the instructions to the correct ones.