Draft
Conversation
Member
|
I think I would like to find a way to drop the tests.sh wrapper, by either using Now that we have one set of cross-platform binaries, I think the value of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current end-to-end Python test runner is hand-written, and invoked from
ctest. This makes it hard to run single specific tests - they don't have standalone entry points, and we can't pass extra args toctestfor filtering.The current solution is to comment out specific tests. That's manual and error-prone. I think we should make the runner richer, and able to apply this filtering.
There was a regex
-Roption for when you calledpython ../tests/... ...directly, but I don't think that's a common use case. This approach uses an envvar instead, which isn't ideal, but is a sensible way to plumb something past ctest. So it works whether you callpython ...orctest ....Opening for discussion now. For full utility, we'd want to improve our
@reqs.descriptioncoverage (this only filters the test functions that are correctly decorated!), but I think we should do that as a separate pass.