Add configurable backup snapshot fetching from primary#7695
Add configurable backup snapshot fetching from primary#7695
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
|
@copilot drop the max_size constraint and configuration, it is not necessary here. |
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
|
@copilot ok actually we need one more thing in the configuration here: the name of the rpc_interface to use on the target node to download the snapshot. That has to be used when grabbing the network details of the primary from the KK to attempt the fetch from it in the BackupSnapshotFetch task. We can't just take the first interface, it may not have the SnapshotRead feature enabled on it. |
The BackupSnapshotFetch task now looks up the primary's RPC interface by name (configured via target_rpc_interface) instead of using the first available interface. This ensures the correct interface with SnapshotRead enabled is used for downloading snapshots. Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Added |
|
@copilot run ./scripts/ci-checks.sh -f to format the code |
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.