fix: make streaming parser more stable and add a fallback#5808
Open
fix: make streaming parser more stable and add a fallback#5808
Conversation
OEvgeny
commented
Apr 16, 2026
| throw new Error('Failed to extract definition token offset'); | ||
| } | ||
|
|
||
| lastStepDefinitionOffset = lastDefinitionTokenOffset; |
Collaborator
Author
There was a problem hiding this comment.
No reliable way to flip it so definitions appear at the end allowing us to drop the offset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Changelog Entry
Description
This change stabilizes
createStreamingRendererby improving incremental Markdown parsing and adding a fallback on error. It also preserves link reference definitions across streaming commits so links continue to resolve correctly as streamed content grows.Design
The main idea is to fed known definitions back to the parser instead of trying to resume the parser state which is hidden in the closure.
Specific Changes
createStreamingRenderer.ts
STREAMING_ERRORsymbol and wrapper error metadata.extractDefinitions,step,commit,cleanup, andreverthelper logic.createStreamingRenderer.spec.ts
Checklist
I have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed