fix(component/ErrorBox): correct 'occured' -> 'occurred' fallback message#5806
Open
SAY-5 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(component/ErrorBox): correct 'occured' -> 'occurred' fallback message#5806SAY-5 wants to merge 1 commit intomicrosoft:mainfrom
SAY-5 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…sage
The fallback Error rectifier in
packages/component/src/ErrorBox.tsx constructed
new Error('Unknown error occured') when the source error was a
non-Error value. The message ends up rendered to end users in the
WebChat error box. String-literal-only change.
SAY-5
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath and
tdurnford
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback
Errorrectifier inpackages/component/src/ErrorBox.tsx:45constructednew Error('Unknown error occured')when the source error was a non-Error value. The message ends up rendered to end users in the WebChat error box. String-literal-only change.