Fix send box should narrate aria-label#5805
Open
compulim wants to merge 5 commits intomicrosoft:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes an accessibility gap where the send box’s aria-label could be provided but not rendered onto the underlying <input> / <textarea> element.
Changes:
- Forward
aria-labelto the underlying<input>(AccessibleInputText) and<textarea>(TextArea). - Add runtime prop validation schemas (valibot) for AccessibleInputText and TextArea.
- Add HTML-based accessibility tests covering
aria-labelfor single-line, multi-line, and Fluent scenarios.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/component/src/Utils/AccessibleInputText.tsx | Adds aria-label forwarding and introduces runtime prop validation via valibot schema. |
| packages/component/src/TextArea/TextArea.tsx | Adds aria-label forwarding and introduces runtime prop validation via valibot schema. |
| tests/html2/accessibility/sendBox/ariaLabel.html | New test verifying aria-label is applied for single-line send box (INPUT). |
| tests/html2/accessibility/sendBox/ariaLabel.multilineTextBox.html | New test verifying aria-label is applied for multiline send box (TEXTAREA). |
| tests/html2/accessibility/sendBox/ariaLabel.fluent.html | New test verifying aria-label is applied in Fluent setup. |
| CHANGELOG.md | Adds changelog entry for the aria-label fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
aria-labelprop, by @compulim, in PR #5805Description
This is fixing
aria-labelthat was passed but never render into HTML element.Specific Changes
<input>and<textarea>to forward thearia-labelpropCHANGELOG.mdI have updated documentationReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)