fix(uairctl): strip \0 delimiter and flush listen output#31
Open
xav-ie wants to merge 1 commit intometent:mainfrom
Open
fix(uairctl): strip \0 delimiter and flush listen output#31xav-ie wants to merge 1 commit intometent:mainfrom
xav-ie wants to merge 1 commit intometent:mainfrom
Conversation
read_until(b'\0') includes the delimiter in the buffer, corrupting output. Use writeln + flush so each update is a newline-terminated, immediately-flushed line for consumers like waybar. Fixes metent#15
xav-ie
force-pushed
the
fix/uairctl-listen-null-delimiter
branch
from
3ac702d to
1842fbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(uairctl): strip \0 delimiter and flush listen output
read_until(b'\0') includes the delimiter in the buffer, corrupting
output. Use writeln + flush so each update is a newline-terminated,
immediately-flushed line for consumers like waybar.
Fixes uairctl listen prepends null terminators to every string except the first one #15