`fn read_pal_uv`: Cleanup and make mostly safe#254

Merged

kkysen merged 22 commits intomainfrom

kkysen/cleanup-fn-read_pal_uv

May 24, 2023

Commits on May 24, 2023

`fn read_pal_uv`: Make local `fn` non-`extern "C"`.
kkysen
committed
`fn read_pal_uv`: Make `t` arg a ref.
kkysen
committed
`fn read_pal_uv`: Make `b` arg a ref.
kkysen
committed
`fn read_pal_uv`: Make `ts` var a ref.
kkysen
committed
`fn read_pal_uv`: Make `f` var a ref.
kkysen
committed
`fn read_pal_uv`: Make `pal` var a slice (and hoist `DEBUG_BLOCK_INFO` call to fix the borrowck error).
kkysen
committed
`fn read_pal_uv`: Remove `_[0-9]+` var suffixes.
kkysen
committed
`fn read_pal_uv`: Translate `printf`s as `print{,ln}!`s.
kkysen
committed
`fn read_pal_uv`: Use accessor methods for `.pal_sz`.
kkysen
committed
`fn read_pal_uv`: Cleanup `as` casts.
kkysen
committed
`fn read_pal_uv`: Replace `.wrapping*` calls with normal arithmetic.
kkysen
committed
`fn read_pal_uv`: Translate `for` loops.
kkysen
committed
`fn read_pal_uv`: Remove `fresh[0-9]+` vars.
kkysen
committed
`fn read_pal_uv`: Make `bits` var a `u32` to reduce casts.
kkysen
committed
`fn read_pal_uv`: Make parentheses around `&` clearer.
kkysen
committed
`fn read_pal_uv`: Make `prev` a `u16` reduce casts.
kkysen
committed
`fn read_pal_uv`: Make `delta` an `i16`.
kkysen
committed
`fn read_pal_uv`: Slice `pal` to `b.pal_sz()[1]` len and use `pal.len()` instead of `b.pal_sz()[1]`.
kkysen
committed
`fn read_pal_uv`: Replace indexing loops with iterators and slices.
kkysen
committed
`fn read_pal_uv`: Use `.fill_with` instead of a loop.
kkysen
committed
`fn read_pal_uv`: Reverse the order of `pal[i]` and `prev` writes (originally were a double assign).
kkysen
committed
`fn read_pal_uv`: Add back comments and spacing/line breaks from C.
kkysen
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`fn read_pal_uv`: Cleanup and make mostly safe#254

`fn read_pal_uv`: Cleanup and make mostly safe#254
kkysen merged 22 commits intomainfrom
kkysen/cleanup-fn-read_pal_uv

Commits on May 24, 2023

`fn read_pal_uv`: Make local `fn` non-`extern "C"`.

`fn read_pal_uv`: Make `t` arg a ref.

`fn read_pal_uv`: Make `b` arg a ref.

`fn read_pal_uv`: Make `ts` var a ref.

`fn read_pal_uv`: Make `f` var a ref.

`fn read_pal_uv`: Make `pal` var a slice (and hoist `DEBUG_BLOCK_INFO` call to fix the borrowck error).

`fn read_pal_uv`: Remove `_[0-9]+` var suffixes.

`fn read_pal_uv`: Translate `printf`s as `print{,ln}!`s.

`fn read_pal_uv`: Use accessor methods for `.pal_sz`.

`fn read_pal_uv`: Cleanup `as` casts.

`fn read_pal_uv`: Replace `.wrapping*` calls with normal arithmetic.

`fn read_pal_uv`: Translate `for` loops.

`fn read_pal_uv`: Remove `fresh[0-9]+` vars.

`fn read_pal_uv`: Make `bits` var a `u32` to reduce casts.

`fn read_pal_uv`: Make parentheses around `&` clearer.

`fn read_pal_uv`: Make `prev` a `u16` reduce casts.

`fn read_pal_uv`: Make `delta` an `i16`.

`fn read_pal_uv`: Slice `pal` to `b.pal_sz()[1]` len and use `pal.len()` instead of `b.pal_sz()[1]`.

`fn read_pal_uv`: Replace indexing loops with iterators and slices.

`fn read_pal_uv`: Use `.fill_with` instead of a loop.

`fn read_pal_uv`: Reverse the order of `pal[i]` and `prev` writes (originally were a double assign).

`fn read_pal_uv`: Add back comments and spacing/line breaks from C.