Merged
Conversation
add collection_copy, collection_source_list fix collection_update, _collection_params
philbudne
approved these changes
Apr 14, 2026
Contributor
philbudne
left a comment
philbudne
left a comment
There was a problem hiding this comment.
Looks good. A small operational question (for the web-search clone-db.sh script) on whether we should disable most users in staging?
| from mediacloud.mgmt import DirectoryManagementApi | ||
|
|
||
| # Directory management integration checks against Tarbell staging (see mediacloud.org deployment). | ||
| MCWEB_STAGING_API_BASE = "https://mcweb-staging.tarbell.mediacloud.org/api/" |
Contributor
There was a problem hiding this comment.
Seeing the URL in black and white (or black on green) makes me wonder, should we disable/delete non-staff users when copying mcweb-db for staging???!
Member
Author
There was a problem hiding this comment.
Ah yes, that's a good idea. Except for that I think we probably want at least one non-staff user to test against in staging, like to validate that 403s/401s get thrown as intended for gated features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just building on Phil's work- a small patch so that source_collection_delete is happy and a test suit.