refactor: eliminate all 132 circular dependency cycles in cattool JS bundle#4530
Open
refactor: eliminate all 132 circular dependency cycles in cattool JS bundle#4530
Conversation
Add madge devDependency with a 132-cycle baseline snapshot and a check script that fails on regressions and reports new cycles introduced. Run: yarn check:circular-deps Update baseline after fixes: node check-circular-deps.js --update-baseline
…ring keys Introduce a modal registry pattern to break 51 circular dependency cycles (132→81). Actions now dispatch string keys instead of component references; ModalWindow resolves them via the registry at render time. - Extract TAB, ONBOARDING_STEP, COPY_SOURCE_COOKIE constants to dedicated files - Create ModalKeys constants and modalRegistry for component resolution - Update ModalsActions, CatToolActions, SegmentActions to use string keys - Backward compatible: components can still pass refs directly
…ibling files Break parent→child circular dependencies across 13 settingsPanel component families by extracting shared symbols (contexts, utility functions, constants) into dedicated sibling files. Children now import from leaf modules instead of their parent components. 81 → 40 circular dependency cycles (51% reduction, 70% total from 132).
…bilateral cycles Break 15 circular dependency cycles (40→25) via: - OnBoarding: extract context/socialUrls to OnBoardingContext.js (5 cycles) - ActivityLog: extract context/constants to sibling files (3 cycles) - SegmentFooterTabGlossary: extract icons/constants to GlossaryConstants.js (2 cycles) - UploadFile: extract getPrintableFileSize to UploadFileUtils.js (2 cycles) - SettingsPanel: move DEFAULT_ENGINE_MEMORY to SettingsPanelConstants.js (1 cycle) - DraftMatecatUtils: extract regexWordDelimiter to textConstants.js (3 cycles) Cumulative: 132→25 (81% reduction). Plugins verified clean.
…bilateral cycle Move getIdAttributeRegEx, unescapeHTMLinTags, and unescapeHTMLRecursive into a new htmlUtils.js file to eliminate the tagUtils → textUtils → tagUtils cycle. tagUtils re-exports for backward compatibility. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Replace static imports of CatToolActions, segment_filter, translationMatches, DraftMatecatUtils, setTranslationUtil, OfflineUtils, and SegmentUtils with lazy-require getters. Updates 58+ call sites. These modules form the hub of most remaining circular dependency cycles. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…tils, and offlineUtils SegmentStore: lazy-require DraftMatecatUtils (8 sites). commonUtils: lazy-require OfflineUtils, SegmentActions, SegmentStore, setTranslationUtil (5 sites). offlineUtils: lazy-require setTranslationUtil (1 site). Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…cycle Breaks the last remaining bilateral (CatToolActions <-> offlineUtils). Circular dependency count: 132 -> 0. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
- replace ratchet-based baseline comparison with zero-tolerance check - delete .madge-baseline.json as baseline tracking is no longer needed - script now fails if any circular dependency exists and prints all cycles
- replace dead re-export with direct import so TAB is bound in module scope
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the cattool frontend bundle to eliminate circular dependency cycles (as detected by madge), and adds a CI-style guard script to prevent regressions. This is achieved via a modal key registry, extraction of constants/contexts/utilities into sibling modules, and targeted lazy require() usage at call sites.
Changes:
- Add
check-circular-deps.js+yarn check:circular-depsand includemadgeas a dev dependency. - Introduce modal key registry (
MODAL_KEY+resolveModal) and update actions to reference modals by key instead of importing components. - Break remaining cycles by extracting shared constants/contexts/utils and replacing selected static imports with lazy
require().
Reviewed changes
Copilot reviewed 103 out of 104 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds/updates lock entries for new circular-deps tooling dependencies (madge + transitive deps). |
| public/js/utils/textUtils.js | Updates regexWordDelimiter import to point to extracted constants module. |
| public/js/utils/offlineUtils.js | Replaces static import with lazy require() to break setTranslationUtil cycle. |
| public/js/utils/commonUtils.js | Converts several static imports to lazy require() getters to break cycles. |
| public/js/stores/SegmentStore.js | Lazy-loads DraftMatecatUtils/SegmentUtils to break circular dependencies. |
| public/js/pages/ActivityLog.js | Moves ActivityLog context to a dedicated module and re-exports it. |
| public/js/constants/SegmentTabConstants.js | New shared TAB constants extracted from SegmentFooter. |
| public/js/constants/OnBoardingConstants.js | New shared onboarding step constants extracted from OnBoarding. |
| public/js/constants/ModalKeys.js | New modal key constants + shared cookie constant for modal registry pattern. |
| public/js/components/xliffToTarget/UploadXliff.js | Updates imports to extracted glossary constants and upload file size util. |
| public/js/components/settingsPanel/Tab.js | Switches to extracted SettingsPanel constants module. |
| public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTableContext.js | New extracted context to avoid parent/child import cycles. |
| public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTable.js | Uses extracted SPECIAL_ROWS_ID + extracted table context. |
| public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelRow.js | Updates context import to extracted context module. |
| public/js/components/settingsPanel/SettingsPanelConstants.js | New extracted settings panel constants and default engine metadata. |
| public/js/components/settingsPanel/SettingsPanel.js | Uses extracted DEFAULT_ENGINE_MEMORY (re-exported for compatibility). |
| public/js/components/settingsPanel/ProjectTemplate/TemplateNameInput.js | Switches TEMPLATE_MODIFIERS import to extracted constants. |
| public/js/components/settingsPanel/ProjectTemplate/ProjectTemplateConstants.js | New extracted template modifier constants. |
| public/js/components/settingsPanel/ProjectTemplate/ProjectTemplate.js | Uses extracted TEMPLATE_MODIFIERS (re-exported for compatibility). |
| public/js/components/settingsPanel/ProjectTemplate/MoreMenu.js | Switches TEMPLATE_MODIFIERS import to extracted constants. |
| public/js/components/settingsPanel/ProjectTemplate/CreateUpdateControl.js | Switches TEMPLATE_MODIFIERS import to extracted constants. |
| public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabUtils.js | New extracted TM glossary tab utilities/constants. |
| public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabContext.js | New extracted context to avoid cycles. |
| public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMKeyRow.js | Updates imports to extracted context + utils module. |
| public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMCreateResourceRow.js | Updates imports to extracted context + utils module. |
| public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateSelect.js | Uses extracted SubTemplates context module. |
| public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateNameInput.js | Uses extracted SubTemplates context module. |
| public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateMoreMenu.js | Uses extracted SubTemplates context module. |
| public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateCreateUpdateControl.js | Uses extracted SubTemplates context module. |
| public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateContext.js | New extracted SubTemplates modifiers/helpers/context. |
| public/js/components/settingsPanel/Contents/SubTemplates/SubTemplate.js | Imports/re-exports from extracted SubTemplateContext. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityRow.js | Uses extracted QualityFramework tab context module. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityColumn.js | Uses extracted QualityFramework tab context module. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTabContext.js | New extracted context to avoid cycles. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTab.js | Uses extracted QualityFramework tab context (re-exported). |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifySeverity.js | Uses extracted context + extracted Categories/Severities utils. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifyCategory.js | Uses extracted context + extracted Categories/Severities utils. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/EptThreshold.js | Uses extracted QualityFramework tab context module. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoryRow.js | Uses extracted context + extracted Categories/Severities utils. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTableUtils.js | New extracted helper functions from CategoriesSeveritiesTable. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTable.js | Re-exports helpers from extracted utils and uses extracted context. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverityCell.js | Uses extracted QualityFramework tab context module. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverity.js | Uses extracted context + extracted helper util. |
| public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddCategory.js | Uses extracted context + extracted helper utils. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/MachineTranslationTab.js | Updates DEFAULT_ENGINE_MEMORY import to extracted constants file. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryRow.js | Switches MT glossary status import to extracted constants. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryCreateRow.js | Switches MT glossary status/constants import to extracted constants. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryConstants.js | New extracted MT glossary status class/constants. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryCreateRow.js | Switches constants import to extracted DeepL constants file. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryConstants.js | New extracted DeepL glossary constants. |
| public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossary.js | Uses extracted DeepL glossary constants (re-exported). |
| public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettingsContext.js | New extracted XliffSettings context. |
| public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettings.js | Uses extracted XliffSettings context (re-exported). |
| public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff20.js | Updates context import to extracted context module. |
| public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff12.js | Updates context import to extracted context module. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Yaml.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Xml.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsWord.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsPowerpoint.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsExcel.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Json.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParamsContext.js | New extracted FiltersParams context. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParams.js | Uses extracted FiltersParams context (re-exported). |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Dita.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/AccordionGroupFiltersParams.js | Updates context import to extracted FiltersParamsContext. |
| public/js/components/settingsPanel/Contents/AnalysisTab/BreakdownsTable.js | Switches breakdown constants import to extracted module. |
| public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTabConstants.js | New extracted analysis breakdown constants. |
| public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTab.js | Uses extracted breakdown constants (re-exported). |
| public/js/components/segments/utils/DraftMatecatUtils/textUtils.js | Moves regex delimiter to extracted constants module (re-exported). |
| public/js/components/segments/utils/DraftMatecatUtils/textConstants.js | New extracted regex constants for word delimiter logic. |
| public/js/components/segments/utils/DraftMatecatUtils/tagUtils.js | Extracts HTML utility helpers into htmlUtils.js to avoid cycles. |
| public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js | New extracted HTML unescape/id-regex helpers. |
| public/js/components/segments/utils/DraftMatecatUtils/decodeTagInfo.js | Updates imports to use extracted html utils. |
| public/js/components/segments/SegmentSource.js | Switches glossary constants import to extracted GlossaryConstants. |
| public/js/components/segments/SegmentFooterTabGlossary/TermForm.js | Switches TERM_FORM_FIELDS import to extracted GlossaryConstants. |
| public/js/components/segments/SegmentFooterTabGlossary/SegmentFooterTabGlossary.js | Extracts glossary constants/icons into dedicated module and re-exports. |
| public/js/components/segments/SegmentFooterTabGlossary/GlossaryItem.js | Switches icons import to extracted GlossaryConstants. |
| public/js/components/segments/SegmentFooterTabGlossary/GlossaryConstants.js | New extracted glossary constants + icon components. |
| public/js/components/segments/SegmentFooter.js | Switches TAB constants import to new SegmentTabConstants. |
| public/js/components/onBoarding/SocialButtons.js | Uses extracted OnBoardingContext module. |
| public/js/components/onBoarding/Register.js | Uses extracted onboarding step constants + OnBoardingContext module. |
| public/js/components/onBoarding/PasswordReset.js | Uses extracted onboarding step constants + OnBoardingContext module. |
| public/js/components/onBoarding/OnBoardingContext.js | New extracted onboarding context + social URL config. |
| public/js/components/onBoarding/OnBoarding.js | Uses extracted constants/context and re-exports for compatibility. |
| public/js/components/onBoarding/Login.js | Uses extracted onboarding step constants + OnBoardingContext module. |
| public/js/components/onBoarding/ForgotPassword.js | Uses extracted onboarding step constants + OnBoardingContext module. |
| public/js/components/modals/modalRegistry.js | New modal registry that maps MODAL_KEY strings to modal components. |
| public/js/components/modals/ModalWindow.js | Resolves modal keys to components at render time via modal registry. |
| public/js/components/modals/CopySourceModal.js | Moves cookie constant to shared ModalKeys (re-exported). |
| public/js/components/createProject/UploadGdrive.js | Switches to extracted getPrintableFileSize + glossary constants import. |
| public/js/components/createProject/UploadFileUtils.js | New extracted file-size formatting utility. |
| public/js/components/createProject/UploadFileLocal.js | Switches to extracted getPrintableFileSize + glossary constants import. |
| public/js/components/createProject/UploadFile.js | Uses extracted getPrintableFileSize (re-exported for compatibility). |
| public/js/components/activityLog/FilterColumn.js | Uses extracted ActivityLog context and constants modules. |
| public/js/components/activityLog/ColumnSorting.js | Uses extracted ActivityLog context module. |
| public/js/components/activityLog/ActivityLogTable.js | Extracts column constants and uses extracted ActivityLog context. |
| public/js/components/activityLog/ActivityLogContext.js | New extracted ActivityLog context module. |
| public/js/components/activityLog/ActivityLogConstants.js | New extracted ActivityLog table column definitions. |
| public/js/actions/SegmentActions.js | Removes modal component imports in favor of modal keys + adds lazy-require hubs. |
| public/js/actions/ModalsActions.js | Opens modals via MODAL_KEY (no direct component imports). |
| public/js/actions/CatToolActions.js | Switches modal usage to MODAL_KEY and lazy-loads OfflineUtils. |
| public/img/icons/ChangePassword.js | Fixes React SVG attribute casing (clipPath). |
| package.json | Adds madge devDependency and check:circular-deps script. |
| check-circular-deps.js | New script that fails CI when madge detects circular dependencies. |
- Replace local createContext in TranslationMemoryGlossaryTab with import from extracted TranslationMemoryGlossaryTabContext module to ensure parent and children share the same context object - Fix QualityFrameworkTab test waitFor assertions that compared array to number (always true), making them actually wait for async API data to load - Add explicit ApplicationWrapperContext import to QualityFrameworkTab test to initialize window.eventHandler, previously loaded as side effect through ModalsActions transitive import chain - Remove dead re-exports of extracted context objects from both QualityFrameworkTab and TranslationMemoryGlossaryTab - Remove unused createContext imports
…o canonical sources - remove 14 dead re-export statements left over from circular dependency context extractions (Phase 3A/3C) - redirect ActivityLog.js to import ACTIVITY_LOG_COLUMNS from ActivityLogConstants and ActivityLogContext from ActivityLogContext - redirect CatTool.js and NewProject.js to import DEFAULT_ENGINE_MEMORY from SettingsPanelConstants - redirect AnalysisTab.test.js to import ANALYSIS_BREAKDOWNS from AnalysisTabConstants - move hoisted imports to top-of-file in AnalysisTab.js and DeepLGlossary.js
…orts - remove dead re-export of COPY_SOURCE_COOKIE from CopySourceModal.js - remove dead re-export of TERM_FORM_FIELDS and 5 icons from SegmentFooterTabGlossary.js - remove dead re-export of 3 util functions from CategoriesSeveritiesTable.js - redirect QualityFrameworkTab.test.js import to CategoriesSeveritiesTableUtils (canonical source) - remove unused htmlUtils imports from tagUtils.js - remove unused createRoot import from ModalWindow.js - remove unused socialUrls import from OnBoarding.js
…minate lazy requires - extract 19 pure Flux dispatchers to segmentDispatchActions.js - extract getSegmentsQa, startSegmentQACheck to segmentQaActions.js - extract disableTPOnSegment to tagProjectionActions.js (isolated from lxq chain to avoid DMU→lxq.main cycle) - extract addClassToSegment, removeClassToSegment to segmentClassActions.js - extract updateGlobalWarnings to warningActions.js - extract notification functions to notificationActions.js - extract get/setLastSegmentFromLocalStorage to segmentLocalStorage.js - convert SA→DMU, SA→SU, SA→TM lazy requires to static imports - rewire GlossaryHighlight, QaCheckGlossaryHighlight, searchUtils, lxq.main, speech2text, translationMatches, offlineUtils to import from leaf modules instead of SegmentActions - convert CatToolActions→offlineUtils, useSocketLayer→SegmentStore to static imports - restore dispatchCustomEvent as inline method in commonUtils.js - remove 3 unused lazy-require stubs from SegmentStore Reduces lazy require() count from 12 to 8, unblocking further static import conversions for Vite migration.
…c imports - Extract checkTPEnabled, checkCurrentSegmentTPEnabled, checkTPSupportedLanguage to new tagProjectionUtils.js leaf module - Inline replaceTempTags/restoreTempTags in tagUtils.js to break SS→tagUtils→textUtils→commonUtils→SS cycle - Convert OfflineUtils to direct static import in commonUtils.js - Update tagProjectionActions.js to import from tagProjectionUtils - Reduces lazy require() count from 8 to 5 (remaining are intractable)
🧪 Test-Guard ReportCoverage Analysis: ❌ FAILNo changed source files found in coverage report (threshold: 80%)
Test File Matching: ❌ FAILFile matching: 2 pass, 8 warning, 109 fail
Per-File Evaluation:
|
| File | Verdict | Reason |
|---|---|---|
public/img/icons/ChangePassword.js |
✅ pass | Change is a minor SVG attribute fix, no behavioral change to test. |
public/js/actions/CatToolActions.js |
✅ pass | Refactor imports and notification actions; no new behavior or branches added. |
public/js/actions/ModalsActions.js |
✅ pass | Replaced modal components with keys; no new behavior or branches added. |
public/js/actions/SegmentActions.js |
✅ pass | Mostly import refactor and reorganization; no new behavior or branches added. |
public/js/actions/notificationActions.js |
New notification action creators added; no tests shown for these new actions. | |
public/js/actions/segmentClassActions.js |
New segment class actions added; no tests shown for these new actions. | |
public/js/actions/segmentDispatchActions.js |
No test files or coverage data provided for dispatcher action creators. | |
public/js/actions/segmentQaActions.js |
No test files or coverage data provided for async QA actions with API calls. | |
public/js/actions/tagProjectionActions.js |
No tests or coverage data for tag projection enabling/disabling logic. | |
public/js/actions/warningActions.js |
No tests or coverage data for global warnings update action. | |
public/js/components/activityLog/ActivityLogConstants.js |
✅ pass | Constants only, no behavior to test. |
public/js/components/activityLog/ActivityLogContext.js |
✅ pass | Context creation only, no behavior to test. |
public/js/components/activityLog/ActivityLogTable.js |
No coverage data or tests modified for activity log table component. | |
public/js/components/activityLog/ColumnSorting.js |
No coverage data or tests modified for column sorting component. | |
public/js/components/activityLog/FilterColumn.js |
No coverage data or tests modified for filter column component. | |
public/js/components/createProject/UploadFile.js |
✅ pass | Refactor only, no new behavior; no coverage data. |
public/js/components/createProject/UploadFileLocal.js |
✅ pass | Import changes only, no new behavior; no coverage data. |
public/js/components/createProject/UploadFileUtils.js |
New utility function added, no tests or coverage data. | |
public/js/components/createProject/UploadGdrive.js |
✅ pass | Import changes only, no new behavior; no coverage data. |
public/js/components/header/cattol/search/searchUtils.js |
Modified to use new dispatch actions but no tests or coverage data provided. | |
public/js/components/modals/CopySourceModal.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/modals/ModalWindow.js |
Added modal resolution logic, no tests or coverage data provided. | |
public/js/components/modals/modalRegistry.js |
New modal registry added, no tests or coverage data provided. | |
public/js/components/onBoarding/ForgotPassword.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/onBoarding/Login.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/onBoarding/OnBoarding.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/onBoarding/OnBoardingContext.js |
New context added, no tests or coverage data provided. | |
public/js/components/onBoarding/PasswordReset.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/onBoarding/Register.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/onBoarding/SocialButtons.js |
✅ pass | Import refactor only, no new behavior; no coverage data. |
public/js/components/segments/GlossaryComponents/GlossaryHighlight.component.js |
Import change and action call updated; no tests shown for new action usage. | |
public/js/components/segments/GlossaryComponents/QaCheckGlossaryHighlight.component.js |
Similar import and action call update; no test evidence for new action usage. | |
public/js/components/segments/SegmentFooter.js |
✅ pass | Replaced constant import; no behavioral change, no test needed. |
public/js/components/segments/SegmentFooterTabGlossary/GlossaryConstants.js |
New constants and icons added; no tests shown to cover these UI elements. | |
public/js/components/segments/SegmentFooterTabGlossary/GlossaryItem.js |
✅ pass | Import path updated; no behavioral change, no test needed. |
public/js/components/segments/SegmentFooterTabGlossary/SegmentFooterTabGlossary.js |
✅ pass | Moved constants to separate file; no behavioral change, no test needed. |
public/js/components/segments/SegmentFooterTabGlossary/TermForm.js |
✅ pass | Import path updated; no behavioral change, no test needed. |
public/js/components/segments/SegmentSource.js |
✅ pass | Import path updated; no behavioral change, no test needed. |
public/js/components/segments/utils/DraftMatecatUtils/decodeTagInfo.js |
✅ pass | Import path changed; no behavioral change, no test needed. |
public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js |
New utility functions added; no tests shown to cover these functions. | |
public/js/components/segments/utils/DraftMatecatUtils/tagUtils.js |
Inlined tag replacement functions and removed redundant code; no tests shown for new logic. | |
public/js/components/segments/utils/DraftMatecatUtils/textConstants.js |
New regex constant added; no tests shown to cover usage. | |
public/js/components/segments/utils/DraftMatecatUtils/textUtils.js |
✅ pass | Removed duplicate regex constant; no behavioral change, no test needed. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifySeverity.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTab.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTabContext.js |
✅ pass | New context created, no behavior to test directly. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityColumn.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityRow.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplate.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateContext.js |
✅ pass | New context and constants created, no behavior to test directly. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateCreateUpdateControl.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateMoreMenu.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateNameInput.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateSelect.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMCreateResourceRow.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMKeyRow.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTab.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabContext.js |
✅ pass | New context created, no behavior to test directly. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabUtils.js |
New utility functions added, no direct tests shown for them. | |
public/js/components/settingsPanel/ProjectTemplate/CreateUpdateControl.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/ProjectTemplate/MoreMenu.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/ProjectTemplate/ProjectTemplate.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/ProjectTemplate/ProjectTemplateConstants.js |
✅ pass | New constants added, no behavior to test directly. |
public/js/components/settingsPanel/ProjectTemplate/TemplateNameInput.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/SettingsPanel.js |
✅ pass | Only removed unused constant, no behavioral changes to test. |
public/js/components/settingsPanel/SettingsPanelConstants.js |
✅ pass | New constants added, no behavior to test directly. |
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelRow.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTable.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTableContext.js |
✅ pass | New context created, no behavior to test directly. |
public/js/components/settingsPanel/Tab.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/components/xliffToTarget/UploadXliff.js |
✅ pass | Only import path changes, no behavioral changes to test. |
public/js/constants/ModalKeys.js |
✅ pass | New constants added, no behavior to test directly. |
public/js/constants/OnBoardingConstants.js |
✅ pass | New constants added, no behavior to test directly. |
public/js/constants/SegmentTabConstants.js |
No tests or coverage data for new constant definitions. | |
public/js/hooks/useSocketLayer.js |
✅ pass | Only import style changed, no behavioral change to test. |
public/js/pages/ActivityLog.js |
✅ pass | Only import and context cleanup, no new behavior to test. |
public/js/pages/CatTool.js |
✅ pass | Only import path fix, no behavioral change to test. |
public/js/pages/NewProject.js |
✅ pass | Only import path fix, no behavioral change to test. |
public/js/stores/SegmentStore.js |
Significant logic changes with tag projection and segment transformations lack coverage evidence. | |
public/js/utils/commonUtils.js |
Refactor to lazy load and import helpers, no new behavior tested. | |
public/js/utils/lxq.main.js |
Refactor to use new action imports, no new behavior tested. | |
public/js/utils/offlineUtils.js |
Refactor to use new action imports, no new behavior tested. | |
public/js/utils/segmentLocalStorage.js |
New localStorage helper functions added with no test coverage evidence. | |
public/js/utils/speech2text.js |
Refactor to use new action imports, no new behavior tested. | |
public/js/utils/tagProjectionUtils.js |
New tag projection utility functions added with no test coverage evidence. | |
public/js/utils/textUtils.js |
✅ pass | Only import path fix, no behavioral change to test. |
public/js/components/segments/utils/translationMatches.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTab.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTabConstants.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/AnalysisTab/BreakdownsTable.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/AccordionGroupFiltersParams.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Dita.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParams.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParamsContext.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Json.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsExcel.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsPowerpoint.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsWord.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Xml.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Yaml.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff12.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff20.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettings.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettingsContext.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossary.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryConstants.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryCreateRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryConstants.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryCreateRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MachineTranslationTab.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddCategory.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverity.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverityCell.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTable.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTableUtils.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoryRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/EptThreshold.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifyCategory.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
Result:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment on lines
+46
to
+50
| <div | ||
| dangerouslySetInnerHTML={{ | ||
| __html: | ||
| 'Smart machine translation that learns from your corrections for enhanced quality and productivity thanks to ModernMT\'s basic features. To unlock all features, <a target="_blank" href="https://www.modernmt.com/pricing#translators">click here</a>.', | ||
| }} |
There was a problem hiding this comment.
The HTML injected here includes an <a target="_blank"> link without rel="noopener noreferrer", which enables reverse-tabnabbing. Add the rel attribute to the link in the injected HTML (or avoid dangerouslySetInnerHTML for this entirely).
Comment on lines
103
to
109
| mine: orderTmKeys(mine, keysOrdered), | ||
| anonymous: [], | ||
| }) | ||
| } | ||
|
|
||
| export const TranslationMemoryGlossaryTabContext = createContext({}) | ||
| import {TranslationMemoryGlossaryTabContext} from './TranslationMemoryGlossaryTabContext' | ||
|
|
There was a problem hiding this comment.
SPECIAL_ROWS_ID/orderTmKeys/getTmDataStructureToSendServer were extracted to TranslationMemoryGlossaryTabUtils.js, but this file still defines and exports its own copies. That duplication is easy to let drift; consider importing these helpers from the new *Utils module here too and removing the local implementations.
Comment on lines
+7
to
35
| // replaceTempTags/restoreTempTags inlined from textUtils to avoid | ||
| // the cycle: SegmentStore → tagUtils → textUtils → commonUtils → SegmentStore | ||
| const replaceTempTags = (text) => { | ||
| const tags = [] | ||
| const makeid = (len) => { | ||
| let r = '' | ||
| const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz' | ||
| for (let i = 0; i < len; i++) | ||
| r += chars.charAt(Math.floor(Math.random() * chars.length)) | ||
| return r | ||
| } | ||
| text = text.replace( | ||
| /<(\/)*(g|x|bx|ex|bpt|ept|ph|it|mrk).*?>/gi, | ||
| (match) => { | ||
| const id = makeid(5) | ||
| tags.push({id, match}) | ||
| return '#_' + id + '_#' | ||
| }, | ||
| ) | ||
| return {tags, text} | ||
| } | ||
| const restoreTempTags = (tags, text) => | ||
| text.replace(/#_([a-zA-Z]+?)_#/gi, (match, id) => { | ||
| const tag = tags.find((item) => item.id === id) | ||
| return tag ? tag.match : match | ||
| }) | ||
| import {isUndefined} from 'lodash' | ||
| import getEntities from './getEntities' | ||
| import matchTagStructure from './matchTag' |
There was a problem hiding this comment.
tagUtils.js now has import statements after executable code (replaceTempTags/restoreTempTags). In ES modules this is a syntax error (imports must come first) and will break bundling/runtime. Move these helper functions below all imports, or extract them to a separate module that can be imported normally.
Comment on lines
+74
to
+78
| const resolvedComponent = resolveModal(component) | ||
| this.setState({ | ||
| ...initialState, | ||
| title, | ||
| component, | ||
| component: resolvedComponent, |
There was a problem hiding this comment.
resolveModal() can return undefined for an unknown modal key; ModalWindow then stores that in state and later does React.createElement(..., <InjectedComponent />), which will throw because InjectedComponent is not a valid component type. Add a guard (e.g., don’t open the modal / fall back to a known error modal) when resolvedComponent is falsy.
Comment on lines
1435
to
1438
| if ( | ||
| SegmentStore.consecutiveUnlockSegments.length >= 3 && | ||
| !localStorage.getItem(HIDE_UNLOCK_ALL_SEGMENTS_MODAL_STORAGE) | ||
| !localStorage.getItem('unlock-segments-modal' + config.id_job) | ||
| ) { |
There was a problem hiding this comment.
This hardcodes the localStorage key 'unlock-segments-modal' + config.id_job even though UnlockAllSegmentsModal exports HIDE_UNLOCK_ALL_SEGMENTS_MODAL_STORAGE for the same purpose. Import and use the shared constant to avoid accidental drift if the key changes (and to keep the value consistent everywhere).
🧪 Test-Guard ReportCoverage Analysis: ❌ FAILNo changed source files found in coverage report (threshold: 80%)
Test File Matching: ❌ FAILFile matching: 2 pass, 8 warning, 109 fail
Per-File Evaluation:
|
| File | Verdict | Reason |
|---|---|---|
public/img/icons/ChangePassword.js |
✅ pass | Change is a minor SVG attribute fix, no behavioral change to test. |
public/js/actions/CatToolActions.js |
✅ pass | Refactor imports and notification actions; no new behavior or edge cases added. |
public/js/actions/ModalsActions.js |
✅ pass | Replaced modal components with keys; no new behavior or error paths added. |
public/js/actions/SegmentActions.js |
✅ pass | Mostly import and refactor changes; no new logic or branches added. |
public/js/actions/notificationActions.js |
New notification action creators added; no tests shown for these new actions. | |
public/js/actions/segmentClassActions.js |
New segment class actions added; no tests shown for these new actions. | |
public/js/actions/segmentDispatchActions.js |
No coverage data or test changes; actions dispatch without branching or error handling. | |
public/js/actions/segmentQaActions.js |
Complex async logic and error handling present; no test changes or coverage data. | |
public/js/actions/tagProjectionActions.js |
Simple conditional logic; no test changes or coverage data to confirm coverage. | |
public/js/actions/warningActions.js |
Single dispatch function added; no tests or coverage data to confirm coverage. | |
public/js/components/activityLog/ActivityLogConstants.js |
✅ pass | Constants added; no behavior to test. |
public/js/components/activityLog/ActivityLogContext.js |
✅ pass | Context creation only; no behavior to test. |
public/js/components/activityLog/ActivityLogTable.js |
✅ pass | Refactor imports only; no behavior changes or tests needed. |
public/js/components/activityLog/ColumnSorting.js |
✅ pass | Import path change only; no behavior changes or tests needed. |
public/js/components/activityLog/FilterColumn.js |
✅ pass | Import path change only; no behavior changes or tests needed. |
public/js/components/createProject/UploadFile.js |
✅ pass | Removed unused function; no behavior changes or tests needed. |
public/js/components/createProject/UploadFileLocal.js |
✅ pass | Import path changes only; no behavior changes or tests needed. |
public/js/components/createProject/UploadFileUtils.js |
New utility function added; no tests or coverage data to confirm coverage. | |
public/js/components/createProject/UploadGdrive.js |
✅ pass | Import path changes only; no behavior changes or tests needed. |
public/js/components/header/cattol/search/searchUtils.js |
Calls to new dispatch actions added; no test changes or coverage data. | |
public/js/components/modals/CopySourceModal.js |
✅ pass | Constant import changed; no behavior changes or tests needed. |
public/js/components/modals/ModalWindow.js |
Modal resolution logic added; no tests or coverage data to confirm coverage. | |
public/js/components/modals/modalRegistry.js |
New modal registry added; no tests or coverage data to confirm coverage. | |
public/js/components/onBoarding/ForgotPassword.js |
✅ pass | Import paths changed; no behavior changes or tests needed. |
public/js/components/onBoarding/Login.js |
✅ pass | Import paths changed; no behavior changes or tests needed. |
public/js/components/onBoarding/OnBoarding.js |
✅ pass | Import paths changed; no behavior changes or tests needed. |
public/js/components/onBoarding/OnBoardingContext.js |
New context and constants added; no tests or coverage data to confirm coverage. | |
public/js/components/onBoarding/PasswordReset.js |
✅ pass | Import paths changed; no behavior changes or tests needed. |
public/js/components/onBoarding/Register.js |
✅ pass | Import paths changed; no behavior changes or tests needed. |
public/js/components/onBoarding/SocialButtons.js |
✅ pass | Import paths changed; no behavior changes or tests needed. |
public/js/components/segments/GlossaryComponents/GlossaryHighlight.component.js |
✅ pass | Tests likely cover glossary term highlighting behavior with updated action import. |
public/js/components/segments/GlossaryComponents/QaCheckGlossaryHighlight.component.js |
✅ pass | Tests likely cover glossary term highlighting in QA check with updated action import. |
public/js/components/segments/SegmentFooter.js |
✅ pass | Change is import refactor; no behavioral change needing tests. |
public/js/components/segments/SegmentFooterTabGlossary/GlossaryConstants.js |
✅ pass | New constants and icons added; no behavior to test directly. |
public/js/components/segments/SegmentFooterTabGlossary/GlossaryItem.js |
✅ pass | Import path fix only; no behavioral change needing tests. |
public/js/components/segments/SegmentFooterTabGlossary/SegmentFooterTabGlossary.js |
✅ pass | Refactor imports and remove inline icons; no new behavior to test. |
public/js/components/segments/SegmentFooterTabGlossary/TermForm.js |
✅ pass | Import path fix only; no behavioral change needing tests. |
public/js/components/segments/SegmentSource.js |
✅ pass | Import path fix only; no behavioral change needing tests. |
public/js/components/segments/utils/DraftMatecatUtils/decodeTagInfo.js |
✅ pass | Import path fix only; no behavioral change needing tests. |
public/js/components/segments/utils/DraftMatecatUtils/htmlUtils.js |
New utility functions added; no tests shown to cover these utilities. | |
public/js/components/segments/utils/DraftMatecatUtils/tagUtils.js |
Refactor tag utils with inlined functions; no tests shown for new logic. | |
public/js/components/segments/utils/DraftMatecatUtils/textConstants.js |
New regex constant added; no tests shown to cover this. | |
public/js/components/segments/utils/DraftMatecatUtils/textUtils.js |
✅ pass | Removed duplicate regex constant; no behavioral change needing tests. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifySeverity.js |
✅ pass | No new behavior or branches introduced; only import path changes. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTab.js |
✅ pass | Only import refactor; no behavioral changes to test. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/QualityFrameworkTabContext.js |
✅ pass | New context created; no behavior to test directly. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityColumn.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/SeverityRow.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplate.js |
✅ pass | Only import refactor; no new behavior introduced. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateContext.js |
✅ pass | New context and constants created; no behavior to test directly. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateCreateUpdateControl.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateMoreMenu.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateNameInput.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/Contents/SubTemplates/SubTemplateSelect.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMCreateResourceRow.js |
✅ pass | Only import refactor; no new behavior introduced. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TMKeyRow.js |
✅ pass | Only import refactor; no new behavior introduced. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTab.js |
✅ pass | Only import refactor; no new behavior introduced. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabContext.js |
✅ pass | New context created; no behavior to test directly. |
public/js/components/settingsPanel/Contents/TranslationMemoryGlossaryTab/TranslationMemoryGlossaryTabUtils.js |
New utility functions added; no direct tests shown but likely covered indirectly. | |
public/js/components/settingsPanel/ProjectTemplate/CreateUpdateControl.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/ProjectTemplate/MoreMenu.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/ProjectTemplate/ProjectTemplate.js |
✅ pass | Only import refactor; no new behavior introduced. |
public/js/components/settingsPanel/ProjectTemplate/ProjectTemplateConstants.js |
✅ pass | New constants added; no behavior to test directly. |
public/js/components/settingsPanel/ProjectTemplate/TemplateNameInput.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/SettingsPanel.js |
✅ pass | Removed unused constant; no behavioral change. |
public/js/components/settingsPanel/SettingsPanelConstants.js |
✅ pass | New constants added; no behavior to test directly. |
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelRow.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTable.js |
✅ pass | Only import refactor; no new behavior introduced. |
public/js/components/settingsPanel/SettingsPanelTable/SettingsPanelTableContext.js |
✅ pass | New context created; no behavior to test directly. |
public/js/components/settingsPanel/Tab.js |
✅ pass | Only import path update; no new behavior. |
public/js/components/xliffToTarget/UploadXliff.js |
✅ pass | Only import path updates; no new behavior introduced. |
public/js/constants/ModalKeys.js |
✅ pass | New constants added; no behavior to test directly. |
public/js/constants/OnBoardingConstants.js |
✅ pass | New constants added; no behavior to test directly. |
public/js/constants/SegmentTabConstants.js |
No tests or coverage data for new constant definitions. | |
public/js/hooks/useSocketLayer.js |
✅ pass | Only import style changed, no behavioral change to test. |
public/js/pages/ActivityLog.js |
✅ pass | Only import and context cleanup, no new behavior to test. |
public/js/pages/CatTool.js |
✅ pass | Only import path changes, no new behavior to test. |
public/js/pages/NewProject.js |
✅ pass | Only import path changes, no new behavior to test. |
public/js/stores/SegmentStore.js |
Behavioral changes with tag projection and segment transformations lack explicit test coverage evidence. | |
public/js/utils/commonUtils.js |
Refactor to lazy-load actions and utilities, no new behavior tested explicitly. | |
public/js/utils/lxq.main.js |
Refactor to use new action imports, no new behavior tested explicitly. | |
public/js/utils/offlineUtils.js |
Refactor to use new action imports, no new behavior tested explicitly. | |
public/js/utils/segmentLocalStorage.js |
New localStorage utility functions added without test coverage evidence. | |
public/js/utils/speech2text.js |
Refactor to use new action imports, no new behavior tested explicitly. | |
public/js/utils/tagProjectionUtils.js |
New tag projection utility functions added without test coverage evidence. | |
public/js/utils/textUtils.js |
✅ pass | Only import path changed, no new behavior to test. |
public/js/components/segments/utils/translationMatches.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTab.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/AnalysisTab/AnalysisTabConstants.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/AnalysisTab/BreakdownsTable.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/AccordionGroupFiltersParams.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Dita.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParams.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/FiltersParamsContext.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Json.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsExcel.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsPowerpoint.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/MsWord.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Xml.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/FiltersParams/Yaml.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff12.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/Xliff20.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettings.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/FileImportTab/XliffSettings/XliffSettingsContext.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossary.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryConstants.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/DeepLGlossary/DeepLGlossaryCreateRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryConstants.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryCreateRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MTGlossary/MTGlossaryRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/MachineTranslationTab/MachineTranslationTab.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddCategory.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverity.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/AddSeverityCell.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTable.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoriesSeveritiesTableUtils.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/CategoryRow.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/EptThreshold.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
public/js/components/settingsPanel/Contents/QualityFrameworkTab/ModifyCategory.js |
⏭️ skip | AI analysis unavailable — deferred to Layer 2 |
Result:
- @translated/lara: 1.8.0-beta.3 → 1.9.0
* feat: add ed error_code to AI Worker messages * fixed phpstan * fixed phpstan * FE integration --------- Co-authored-by: pierluigi.dicianni <pierluigi.dicianni@translated.net>
- regenerate phpstan-baseline.neon to absorb 726 pre-existing @throws violations across 275 files - add phpstan-throws-backlog.txt listing all files to fix sequentially
- create `.github/PULL_REQUEST_TEMPLATE.md` to standardize pull request descriptions - add `.github/workflows/pr-readiness-check.yml` GitHub Action to validate mandatory checklist - implement checklist validation logic in `.github/scripts/pr-readiness-check.js` - include comprehensive unit tests in `.github/scripts/pr-readiness-check.test.js` Signed-off-by: domenico <domenico@translated.net>
- update instructions to only require naming the AI agent/tool used - adjust example to remove implementation + test generation details 🐛 fix(pr-checks): ensure comments are fully removed in section validation - implement loop to repeatedly strip nested HTML comments in `pr-readiness-check.js` 🔧 chore(tests): exclude `.github/scripts` from jest transformations - update `jest.config.js` to add `.github/scripts/` to `transformIgnorePatterns` Signed-off-by: domenico <domenico@translated.net>
- add testPathIgnorePatterns to jest.config.js so Jest does not pick up CI validation scripts that use Node built-in test runner
- add lib/View/APIDoc.php and lib/View/templates/_APIDoc.php to excludePaths in phpstan.neon (webpack build artifacts) - remove 5 stale baseline entries referencing excluded files
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- validate PR title (required gate) and commit messages (hygiene gate) against emoji-prefixed conventional-commit spec - add commit-message-check.js with emoji↔type map, VS16 normalization, format/length/case/period validation, merge-commit skip - add 35 unit tests covering all 12 types, edge cases, and error collection - bypass via `commit-message-exception` label
- add requireEmoji option (default true) to validateCommitMessage so PR title stays strict while commit messages accept emoji-less conventional-commit format (e.g. "docs(qa): ...") - auto-skip GitHub web UI patterns (Update/Create/Delete/Rename) in relaxed mode - update workflow to pass requireEmoji: false for commit-messages job - add 18 new tests for relaxed mode and isGitHubWebEdit (53 total)
…callers Declare checked exceptions on all methods using Database::transaction(), which re-throws \Throwable on rollback. Remove 2 stale baseline entries now covered by the broader @throws declaration.
- run PHPUnit with Xdebug coverage on pull requests - invoke ostico/test-guard@v1.0.1 with 80% coverage threshold - enable AI-powered test adequacy analysis
- move test-guard from standalone workflow into _ci-cd.yml as a PR-only job that consumes coverage from the tests job - extract coverage.xml from test container via docker cp and upload as "coverage-report" artifact - add pull-requests:write and statuses:write permissions to aws_dev.yml and aws_prod.yml callers - set per-job permissions in _ci-cd.yml (test-guard needs write access, other jobs only need contents:read) - update docker submodule (php-pcov + --coverage-clover)
- grant models:read permission in PR workflows for repository access Signed-off-by: domenico <domenico@translated.net>
- update permissions in _ci-cd.yml, aws_prod.yml, and aws_dev.yml - align with GitHub's recommended permissions model Signed-off-by: domenico <domenico@translated.net>
- Add Clover reporter to Jest so it writes js-coverage/clover.xml - Extract both PHP and JS coverage from test container - Pass both files to test-guard via YAML block scalar
🧪 Test-Guard Report❌ FAIL — Some changed source files lack adequate test coverage. Coverage Analysis: ❌ FAILNo changed source files found in coverage report (threshold: 80%)
Test File Matching: ❌ FAILFile matching: 4 pass, 9 warning, 112 fail
Per-File Evaluation: ❌ FAILAI analysis failed (Error code: 413 - {'error': {'code': 'tokens_limit_reached', 'message': 'Request body too large for gpt-4.1-mini model. Max size: 8000 tokens.', 'details': 'Request body too large for gpt-4.1-mini model. Max size: 8000 tokens.'}}) — shortcuts resolved; remaining files deferred to L1+L2.
Result: ❌ FAIL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates all 132 circular dependency cycles detected by madge in the cattool JS bundle, bringing the count to 0. Adds a zero-tolerance checker (
yarn check:circular-deps) to prevent regressions. Additionally reduces lazyrequire()workarounds from 12 to 5 by extracting leaf modules and converting to static imports where safe.Type
feat— new user-facing featurefix— bug fixrefactor— restructure without behavior changechore— build, deps, config, docsperf— performance improvementtest— test coverageChanges
check-circular-deps.jsmadge --circular, fails on any cyclepackage.jsoncheck:circular-depsscriptpublic/js/actions/*.jspublic/js/components/modals/ModalContainer.jspublic/js/components/settingsPanel/*.js(13 new)public/js/constants/SegmentTabConstants.jspublic/js/components/segments/utils/DraftMatecatUtils/htmlUtils.jspublic/js/components/segments/utils/DraftMatecatUtils/tagUtils.jsreplaceTempTags/restoreTempTagsto break SS→tagUtils→textUtils→CU→SS cyclepublic/js/utils/tagProjectionUtils.jscheckTPEnabled,checkCurrentSegmentTPEnabled,checkTPSupportedLanguagepublic/js/actions/tagProjectionActions.jspublic/js/actions/SegmentActions.jspublic/js/actions/segmentDispatchActions.jspublic/js/actions/segmentQaActions.jspublic/js/actions/warningActions.jspublic/js/actions/segmentClassActions.jspublic/js/actions/notificationActions.jspublic/js/utils/segmentLocalStorage.jspublic/js/stores/SegmentStore.jspublic/js/utils/commonUtils.jspublic/js/utils/offlineUtils.jspublic/js/components/segments/SegmentFooter.jsTesting
vendor/bin/phpunit --exclude-group=ExternalServices --no-coveragepasses./vendor/bin/phpstanpasses (0 errors, with baseline)Verification performed:
node check-circular-deps.js→ 0 cycles (was 132)webpack 5.104.1 compiled successfully— verified after every phase (3 pre-existing warnings)yarn test→ 34/34 suites pass, 183 tests, 2 skipped (pre-existing)AI Disclosure
Claude Opus 4 (via OpenCode/Sisyphus agent)
Notes
require()calls remain — these guard bilateral dependencies between hub modules (SegmentActions↔SegmentFilter, SegmentActions↔setTranslationUtil, commonUtils↔SegmentActions, commonUtils↔setTranslationUtil, offlineUtils↔setTranslationUtil) plus 1 plugin-safe call (SegmentStore→segmentUtils forisUnlockedSegment). All are intractable without major architectural changes.require()inside ESM files — this works under webpack but does not block Vite migration. ESM live bindings handle these circular refs natively; therequire()calls can become regularimportstatements when madge is replaced.