Skip to content

base: support min_version check#81

Open
no92 wants to merge 1 commit intomanagarm:masterfrom
no92:min-version
Open

base: support min_version check#81
no92 wants to merge 1 commit intomanagarm:masterfrom
no92:min-version

Conversation

@no92
Copy link
Copy Markdown
Member

@no92 no92 commented Feb 23, 2024

No description provided.

@no92 no92 added the enhancement New feature or request label Feb 23, 2024
Copy link
Copy Markdown
Member

@ElectrodeYT ElectrodeYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qookei
Copy link
Copy Markdown
Member

qookei commented Feb 29, 2024

Should the version check also be reflected in the xbps package dependencies?

@no92
Copy link
Copy Markdown
Member Author

no92 commented Feb 29, 2024

Should the version check also be reflected in the xbps package dependencies?

I wouldn't know why, as this is only about xbstrap features used in the bootstrap.yml and not related to the eventual output.

@qookei
Copy link
Copy Markdown
Member

qookei commented Feb 29, 2024

Oh my bad, I thought this was for package dependency versions, not xbstrap's version itself


import colorama
import jsonschema
import pkg_resources
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to this, we now depend on setuptools. consider instead extracting the version into a file that setup.py reads/imports

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem with depending on setuptools?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that we don't declare it... plus, decently sure this won't work when doing a distro install. there's simply no need

@avdgrinten
Copy link
Copy Markdown
Member

Oh my bad, I thought this was for package dependency versions, not xbstrap's version itself

Maybe the property should be called xbstrap_version to clarify this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants