Skip to content

fix Windows tester feedback, add changelog, bump to 1.1.0-beta.1#5

Merged
dennisdornon merged 3 commits intomainfrom
fix/windows-tester-feedback
Mar 26, 2026
Merged

fix Windows tester feedback, add changelog, bump to 1.1.0-beta.1#5
dennisdornon merged 3 commits intomainfrom
fix/windows-tester-feedback

Conversation

@dennisdornon
Copy link
Copy Markdown
Contributor

@dennisdornon dennisdornon commented Mar 26, 2026

Addresses Windows tester feedback and preps for 1.1.0-beta.1.

  • Fix Windows experience: Git Bash as primary recommendation, PowerShell guidance
  • Fix debug redaction, ctrl-c exit code, CI audit warnings
  • Fix test fixtures: site_idsite_id_or_domain to match real API
  • Show required params in abilities list examples
  • Add CHANGELOG.md with retroactive entries for v1.0.0 and v1.0.1
  • Bump version to 1.1.0-beta.1

Tested locally. All tests pass.

Summary by CodeRabbit

  • New Features

    • Added usage hints and copy-pasteable example commands for abilities.
    • Added a CHANGELOG documenting release history.
  • Documentation

    • Updated examples and workflow docs to use site_id_or_domain.
    • Clarified password quoting guidance for environment variables and cron examples.
  • Bug Fixes

    • CI now treats high-severity audit findings as failures.
  • Tests

    • Updated test fixtures and expectations to use site_id_or_domain.
  • Chores

    • Version bumped to 1.1.0-beta.1.

- Fix Windows tester feedback (Git Bash as primary recommendation)
- Fix debug redaction, ctrl-c exit code, CI audit
- Fix test fixtures: site_id → site_id_or_domain
- Show required params in abilities list examples
- Add CHANGELOG.md with retroactive entries
- Bump version to 1.1.0-beta.1
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7233d31b-73ee-41de-8076-172454c3dc56

📥 Commits

Reviewing files that changed from the base of the PR and between cb3b687 and 6619645.

📒 Files selected for processing (1)
  • CHANGELOG.md
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

Walkthrough

Updates include a version bump to 1.1.0-beta.1, standardization of ability input schemas from site_id to site_id_or_domain across tests and fixtures, stricter CI npm-audit enforcement, generation of per-ability usage hints, a DoctorCommand ability-name adjustment, refined debug redaction logic, and a Ctrl-C exit code change.

Changes

Cohort / File(s) Summary
Schema Field Standardization
src/__tests__/e2e/non-tty-behavior.test.ts, src/__tests__/process/abilities-info.test.ts, src/__tests__/process/abilities-list.test.ts, src/__tests__/process/abilities-run.test.ts, src/__tests__/process/fixtures/api-responses.ts, src/__tests__/process/safety.test.ts, src/__tests__/process/scenarios.test.ts
Replaced site_id with site_id_or_domain in fixtures, mocked inputs, and assertions so tests and mocked ability input schemas expect site_id_or_domain.
Documentation & Changelog
README.md, docs/workflows/daily-health-check.md, docs/workflows/monitoring-integration.md, CHANGELOG.md
Updated examples to use site_id_or_domain; changed cron examples to wrap MAINWP_APP_PASSWORD in single quotes; added a new CHANGELOG.md.
CI & Package Metadata
.github/workflows/ci.yml, package.json
CI: run npm audit --audit-level=high and removed continue-on-error; package version bumped to 1.1.0-beta.1.
Abilities Listing UX
src/commands/abilities/list.ts
Added buildUsageHint and placeholderFor to generate per-ability copy-pasteable abilities run ... --input '<json>' hints populated with schema-derived placeholders.
Doctor Command Adjustment
src/commands/doctor.ts
Doctor ability checks now reference fully-qualified ability names (mainwp/list-sites-v1, mainwp/get-site-v1) for detection and messaging.
Debug Redaction Behavior
src/lib/base-command.ts
Changed redact matching from substring/includes to exact case-insensitive key equality when comparing keys against sensitive keywords.
Prompt Exit Code
src/utils/prompt.ts
Ctrl-C handler in promptForPassword now exits with code 130 (was 1).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the primary changes: fixing Windows feedback, adding a changelog, and bumping the version to 1.1.0-beta.1, all clearly supported by the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-tester-feedback

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CHANGELOG.md`:
- Around line 8-24: Add a new changelog section for the published prerelease:
insert a header and release metadata for "1.1.0-beta.1" immediately above the
"Unreleased" block so the notes match package.json's version; update the top
sections so the current Unreleased items remain under Unreleased and copy or
move the relevant bullet points into the new "1.1.0-beta.1" section as the
published release notes, ensuring you also update the later occurrence around
the 60-62 area that mirrors release headers.

In `@src/lib/base-command.ts`:
- Around line 299-300: The current redaction logic using sensitiveKeys.some(s =>
key.toLowerCase().includes(s)) incorrectly redacts metadata keys like
passwordSource; update the check in the redaction block that produces
redacted[key] to skip known non-secret metadata keys (e.g., 'passwordSource') by
adding an explicit whitelist or a stricter match (exact key equality or
word-boundary regex) before applying sensitiveKeys.some(...), so only true
secrets are redacted while keys like passwordSource remain intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d35b9c1-d5fb-4c06-a2c1-1618185b6988

📥 Commits

Reviewing files that changed from the base of the PR and between adb2b50 and 48cd400.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (17)
  • .github/workflows/ci.yml
  • CHANGELOG.md
  • README.md
  • docs/workflows/daily-health-check.md
  • docs/workflows/monitoring-integration.md
  • package.json
  • src/__tests__/e2e/non-tty-behavior.test.ts
  • src/__tests__/process/abilities-info.test.ts
  • src/__tests__/process/abilities-list.test.ts
  • src/__tests__/process/abilities-run.test.ts
  • src/__tests__/process/fixtures/api-responses.ts
  • src/__tests__/process/safety.test.ts
  • src/__tests__/process/scenarios.test.ts
  • src/commands/abilities/list.ts
  • src/commands/doctor.ts
  • src/lib/base-command.ts
  • src/utils/prompt.ts

- bump picomatch to fix high-severity ReDoS
- use exact key match for redaction so passwordSource isn't redacted
@dennisdornon dennisdornon merged commit e066590 into main Mar 26, 2026
9 checks passed
@dennisdornon dennisdornon deleted the fix/windows-tester-feedback branch March 26, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant