fix Windows tester feedback, add changelog, bump to 1.1.0-beta.1#5
fix Windows tester feedback, add changelog, bump to 1.1.0-beta.1#5dennisdornon merged 3 commits intomainfrom
Conversation
- Fix Windows tester feedback (Git Bash as primary recommendation) - Fix debug redaction, ctrl-c exit code, CI audit - Fix test fixtures: site_id → site_id_or_domain - Show required params in abilities list examples - Add CHANGELOG.md with retroactive entries - Bump version to 1.1.0-beta.1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdates include a version bump to 1.1.0-beta.1, standardization of ability input schemas from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CHANGELOG.md`:
- Around line 8-24: Add a new changelog section for the published prerelease:
insert a header and release metadata for "1.1.0-beta.1" immediately above the
"Unreleased" block so the notes match package.json's version; update the top
sections so the current Unreleased items remain under Unreleased and copy or
move the relevant bullet points into the new "1.1.0-beta.1" section as the
published release notes, ensuring you also update the later occurrence around
the 60-62 area that mirrors release headers.
In `@src/lib/base-command.ts`:
- Around line 299-300: The current redaction logic using sensitiveKeys.some(s =>
key.toLowerCase().includes(s)) incorrectly redacts metadata keys like
passwordSource; update the check in the redaction block that produces
redacted[key] to skip known non-secret metadata keys (e.g., 'passwordSource') by
adding an explicit whitelist or a stricter match (exact key equality or
word-boundary regex) before applying sensitiveKeys.some(...), so only true
secrets are redacted while keys like passwordSource remain intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3d35b9c1-d5fb-4c06-a2c1-1618185b6988
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (17)
.github/workflows/ci.ymlCHANGELOG.mdREADME.mddocs/workflows/daily-health-check.mddocs/workflows/monitoring-integration.mdpackage.jsonsrc/__tests__/e2e/non-tty-behavior.test.tssrc/__tests__/process/abilities-info.test.tssrc/__tests__/process/abilities-list.test.tssrc/__tests__/process/abilities-run.test.tssrc/__tests__/process/fixtures/api-responses.tssrc/__tests__/process/safety.test.tssrc/__tests__/process/scenarios.test.tssrc/commands/abilities/list.tssrc/commands/doctor.tssrc/lib/base-command.tssrc/utils/prompt.ts
- bump picomatch to fix high-severity ReDoS - use exact key match for redaction so passwordSource isn't redacted
Addresses Windows tester feedback and preps for 1.1.0-beta.1.
site_id→site_id_or_domainto match real APIabilities listexamplesTested locally. All tests pass.
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Tests
Chores