Conversation
Original idea of _prepare logic was to ensure that different types of incoming files data is properly transformed into httpx files format. As a result additional logic introduced a bug with attachments. Deeper comparison of 'requests' and 'httpx' libraries shows that they use the same approach to 'files' parameter. So we can drop additional logic and use the same approach as in sync version of Endpoint.
skupriienko
approved these changes
Mar 18, 2026
Collaborator
skupriienko
left a comment
skupriienko
left a comment
There was a problem hiding this comment.
LGTM. Please check that the tests pass and there are no side effects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original idea of
_prepare_fileslogic was to ensure that different types of incoming files data is properly transformed into httpx files format.As a result additional logic introduced a bug with attachments. Deeper comparison of
requestsandhttpxlibraries shows that they use the same approach tofilesparameter.So we can drop additional logic and use the same approach as in sync version of Endpoint.