feat(log): Add json console log formatter#12
Open
rvadim wants to merge 1 commit intomailgun:masterfrom
rvadim:json-console-logger
Open
feat(log): Add json console log formatter#12rvadim wants to merge 1 commit intomailgun:masterfrom rvadim:json-console-logger
rvadim wants to merge 1 commit intomailgun:masterfrom
rvadim:json-console-logger
Conversation
if set log config to name: json_console, messages to stdout will be in json format each message is one object. It is conveniently for sending logs to elastic search storage.
Contributor
There was a problem hiding this comment.
NewJsonConsoleLogger -> NewJSONConsoleLogger (check out https://github.com/golang/go/wiki/CodeReviewComments#initialisms)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If set log config to "name: json_console", messages to stdout will be in
json format each message is one object. It is conveniently for sending
logs to elasticsearch storage.
Tested with master branch of vulcand. Generating messages like
{"appname":"vulcand","filename":"supervisor.go","function":"github.com/vulcand/vulcand/supervisor.initProxy","linenumber":356,"message":"No frontends found","pid":25521,"severity":2,"timestamp":"Nov 30 03:59:00.130"}