feat: migrate google-analytics-4 kit to monorepo#1206
Open
nickolas-dimitrakas wants to merge 6 commits intoworkstation/3.0-Releasefrom
Open
feat: migrate google-analytics-4 kit to monorepo#1206nickolas-dimitrakas wants to merge 6 commits intoworkstation/3.0-Releasefrom
nickolas-dimitrakas wants to merge 6 commits intoworkstation/3.0-Releasefrom
Conversation
Migrates GA4Client and GA4Server packages from mparticle-javascript-integration-google-analytics-4 into the web SDK monorepo under kits/google-analytics-4/. - kits/google-analytics-4/ga4-client (@mparticle/web-google-analytics-4-client-kit v1.5.1) - kits/google-analytics-4/ga4-server (@mparticle/web-google-analytics-4-server-kit v1.0.3) - Updated package.json repository fields to point to monorepo - Added both kits to kits/matrix.json for CI coverage - Applied Prettier formatting to match monorepo code style conventions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test script calls karma but karma was missing from devDependencies. Add karma and browser launcher packages to match the ga4-client kit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Updating package-lock.json to include karma and browser launcher packages added in the previous commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
karma-chai@0.1.0 requires chai v4's browser bundle at chai/chai.js. chai v6 changed its file structure, breaking that path. Pinning chai to ^4.2.0 restores the expected bundle location. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nickolas-dimitrakas
requested review from
a team,
alexs-mparticle,
jaissica12,
khushi1033 and
rmi22186
The original mparticle-javascript-integration-google-analytics-4 repo used a packages/GA4Client + packages/GA4Server layout with a root package.json orchestrator. The migration commit incorrectly flattened this to ga4-client/ and ga4-server/ at the top level and omitted the root package.json. This commit: - Moves ga4-client/ → packages/GA4Client/ (git mv, history preserved) - Moves ga4-server/ → packages/GA4Server/ (git mv, history preserved) - Updates repository.directory in each sub-kit's package.json - Adds root package.json with build/test scripts that delegate to each sub-package via npm --prefix - Adds root package-lock.json (no root deps; required for npm ci) - Collapses the two matrix entries into a single "Google Analytics 4" entry pointing to kits/google-analytics-4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Restores the root-level config files that existed in the original mparticle-integrations/mparticle-javascript-integration-google-analytics-4 repo but were not included in the monorepo migration: - .eslintrc — eslint + prettier config (root: true) - .gitignore — ignores node_modules - .prettierrc — singleQuote, trailingComma: es5, tabWidth: 4 - README.md — usage docs for both client and server kits Also updates package.json description to match the original. The .github/workflows/ are omitted as the monorepo has its own CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
What Changed
Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)