pe.options: added parse_resources option#521
Open
prettyroseslover wants to merge 1 commit intom4b:masterfrom
Open
pe.options: added parse_resources option#521prettyroseslover wants to merge 1 commit intom4b:masterfrom
prettyroseslover wants to merge 1 commit intom4b:masterfrom
Conversation
Contributor
|
Hi, thank you for the PR! Besides do you have any issues with the parser? Or, I guess is with some performance matters?😃 |
Contributor
Author
|
No, I have encountered no issues with the parser, it's more for the performance + malware samples which may have some funky stuff with the resources, but I still want to parse everything apart from that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it's great to have a choice to skip resource parsing. Therefore, I added
ParseOptions.parse_resources. Also, I decided to add a couple of missingwith_methods toParseOptions.