per code PROMREMOTEBENCH_INTERVAL is not relevant for scraping#10
Open
xmcqueen wants to merge 1 commit intom3dbx:masterfrom
Open
per code PROMREMOTEBENCH_INTERVAL is not relevant for scraping#10xmcqueen wants to merge 1 commit intom3dbx:masterfrom
xmcqueen wants to merge 1 commit intom3dbx:masterfrom
Conversation
gibbscullen
suggested changes
Feb 21, 2020
gibbscullen
left a comment
gibbscullen
left a comment
There was a problem hiding this comment.
Does this apply to both the remote write and scrape benchmarking manifests?
Author
|
I'm not sure what you're question is. The PROMREMOTEBENCH_INTERVAL is not used for Scrape Benchmarking as far as I could tell by looking at the code (when promremotebench is being scraped). It IS needed for the Remote Write Benchmarking (when promremotebench is jamming metrics into some remote data store). It should be removed from the Scrape Benchmarking example yaml on the README because users will be very puzzled about what it could mean, when it actually means nothing. This commit is just a change to the README, so people will have a non-confusing first encounter with the tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its confusing for users to wonder about how PROMREMOTEBENCH_INTERVAL might interact with the scraper's own interval. Its actually not used when running in the scrape-target mode. Its best to get this line out of the README.