Skip to content

refactor(android): use regular Marker instead of AdvancedMarker #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lodev09 merged 2 commits into from
Apr 30, 2026
Merged

refactor(android): use regular Marker instead of AdvancedMarker #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca341af
refactor(android): use regular Marker instead of AdvancedMarker
lodev09 Apr 30, 2026
fccf4d3
chore: update clean script
lodev09 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/src/main/java/com/luggmaps/LuggMarkerView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import android.view.accessibility.AccessibilityEvent
import androidx.core.graphics.createBitmap
import androidx.core.view.isNotEmpty
import com.facebook.react.views.view.ReactViewGroup
import com.google.android.gms.maps.model.AdvancedMarker
import com.google.android.gms.maps.model.BitmapDescriptor
import com.google.android.gms.maps.model.BitmapDescriptorFactory
import com.google.android.gms.maps.model.Marker
import com.luggmaps.events.MarkerDragEvent
import com.luggmaps.events.MarkerPressEvent
import com.luggmaps.extensions.dispatchEvent
Expand Down Expand Up @@ -38,7 +38,7 @@ class LuggMarkerView(context: Context) : ReactViewGroup(context) {
private set

var delegate: LuggMarkerViewDelegate? = null
var marker: AdvancedMarker? = null
var marker: Marker? = null

var anchorX: Float = 0.5f
private set
Expand Down
12 changes: 5 additions & 7 deletions android/src/main/java/com/luggmaps/core/GoogleMapProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ import com.google.android.gms.maps.GoogleMap
import com.google.android.gms.maps.GoogleMapOptions
import com.google.android.gms.maps.MapView
import com.google.android.gms.maps.OnMapReadyCallback
import com.google.android.gms.maps.model.AdvancedMarker
import com.google.android.gms.maps.model.AdvancedMarkerOptions
import com.google.android.gms.maps.model.BitmapDescriptorFactory
import com.google.android.gms.maps.model.Circle
import com.google.android.gms.maps.model.CircleOptions
Expand All @@ -26,6 +24,7 @@ import com.google.android.gms.maps.model.LatLng
import com.google.android.gms.maps.model.LatLngBounds
import com.google.android.gms.maps.model.MapColorScheme
import com.google.android.gms.maps.model.Marker
import com.google.android.gms.maps.model.MarkerOptions
import com.google.android.gms.maps.model.Polygon
import com.google.android.gms.maps.model.PolygonOptions
import com.google.android.gms.maps.model.PolylineOptions
Expand Down Expand Up @@ -692,12 +691,12 @@ class GoogleMapProvider(private val context: Context) :
val map = googleMap ?: return

val position = LatLng(markerView.latitude, markerView.longitude)
val options = AdvancedMarkerOptions()
val options = MarkerOptions()
.position(position)
.title(markerView.title)
.snippet(markerView.description)

val marker = map.addMarker(options) as AdvancedMarker
val marker = map.addMarker(options) ?: return
marker.setAnchor(markerView.anchorX, markerView.anchorY)
marker.zIndex = markerView.zIndex
marker.rotation = markerView.rotate
Expand All @@ -715,9 +714,8 @@ class GoogleMapProvider(private val context: Context) :
}
}

// Workaround: AdvancedMarker.iconView is buggy on Android, so we manually add the custom
// content view to the wrapper and position it via screen projection instead. The underlying
// marker uses a transparent bitmap matching the content size so taps still trigger onMarkerClick.
// Live marker: content view is added to the wrapper and positioned via screen projection.
// The underlying marker uses a transparent bitmap matching the content size so taps still trigger onMarkerClick.
private fun showLiveMarker(markerView: LuggMarkerView) {
val wrapper = wrapperView ?: return

Expand Down
4 changes: 2 additions & 2 deletions example/bare/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ PODS:
- hermes-engine (0.14.0):
- hermes-engine/Pre-built (= 0.14.0)
- hermes-engine/Pre-built (0.14.0)
- LuggMaps (1.0.0-beta.6):
- LuggMaps (1.0.0-beta.11):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -3202,7 +3202,7 @@ SPEC CHECKSUMS:
glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
GoogleMaps: 0608099d4870cac8754bdba9b6953db543432438
hermes-engine: 3515eff1a2de44b79dfa94a03d1adeed40f0dafe
LuggMaps: ae94261b276434379240235ff85192dcc541d66c
LuggMaps: 91958164a9ad4932293c33caf8386a35d478e914
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
RCTDeprecation: 2b70c6e3abe00396cefd8913efbf6a2db01a2b36
RCTRequired: f3540eee8094231581d40c5c6d41b0f170237a81
Expand Down
2 changes: 1 addition & 1 deletion scripts/clean.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ clean_bare_example() {
cd example/bare/android
./gradlew clean -q
cd ../../..
npx pod-install example/bare
cd example/bare/ios && pod install && cd ../../..
}

clean_expo_example() {
Expand Down
Loading