Fix NUKE_CERT variables to be case insensitive in bash#536
Open
Fix NUKE_CERT variables to be case insensitive in bash#536
Conversation
Use ${VAR,,} parameter expansion for case-insensitive comparisons
in bash. Also fix bug where FORCE_NUKE_CERTS was compared as a
literal string instead of a variable value.
The GitHub Actions if: expressions (nuke_certs job) are already
case-insensitive, so no changes needed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${VAR,,}bash parameter expansion for case-insensitive comparisons instead of introducing_LChelper variables (supersedes make the NUKE_CERT variables case insensitive #528)FORCE_NUKE_CERTSwas compared as the literal stringvars.FORCE_NUKE_CERTSinstead of the actual variable valueFORCE_NUKE_CERTS=${{ vars.FORCE_NUKE_CERTS }}assignment so bash has access to the variablenuke_certsjobif:condition since GitHub Actions==is already case-insensitiveTest plan
ENABLE_NUKE_CERTStoTrue,TRUE, andtrue— all should be recognizedFORCE_NUKE_CERTStoTrue,TRUE, andtrue— all should trigger the force warning annotationFORCE_NUKE_CERTStofalseor unset — no force warning annotationnuke_certsjob still triggers correctly based on the GitHub Actionsif:expression