Closed
Conversation
fixing deadlock
dpos migration testing
Disable dupl linter
* Sanitize req.ValidatorAddress * Throw if validator address has invalid chain id instead of fixing it for clients
fixing logic
undoubled delegation & migration testing
DPOSv2.1 Fix Whitelist multiplier bug
* take bonuses into account when rewarding whitelists * add test for correct whitelist reward bonuses after many elections
adjusting tests to work with new calculateRewards func
Remove Statistic.Pubkey in dposv3
adding SetMinCandidateFee command
* eth_getCode for go-contracts * eth_getCode for go-contracts * eth_getCode for go-contracts * Returning simple contract code
- Remove unused flags from CLI commands. - Fix e2e tests that invoked CLI commands with unnecessary flags.
Previously these JSON-RPC endpoints loaded tx info from the Tendermint tx index DB, which on some clusters might be missing info for older txs. Since most of the relevant tx info can be decoded from the tx bytes within a block that's what these endpoints do now instead of relying on the tx index DB.
Lock down `google.golang.org/genproto` to avoid `pb.go` compiled with a newer protoc/gogo protobuf version than ours.
The caching store doesn't work with the multi writer app store snapshots, so the snapshots bypass the cache, which means the QueryServer never hits the cache in the caching store, no point writing to the cache if nothing ever reads from it. Also simplified the Range implementation of the multi writer app store and the EVM store, we don't really use Range(nil) anywhere, and there was a lot of code to support that use case that just added a lot of additional complexity.
MultiWriterAppStore for EVM state migration
enlight
requested changes
May 15, 2019
Contributor
enlight
left a comment
enlight
left a comment
There was a problem hiding this comment.
Why are there two chain IDs for EOS (eos & eos-scatter), tx signature has a type prefix so it should be possible to figure out which method was used to sign and handle everything with a single chain ID.
removing unused constants + timings are fixed
# Conflicts: # Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes moved from #865
Requires loomnetwork/go-loom#311